Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with ASM span tags reporting the number of WAF failed loaded rules #1555

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fix a bug with ASM span tags reporting the number of WAF failed loaded rules #1555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/appsec/waf/test_reports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import pytest

from tests.constants import PYTHON_RELEASE_GA_1_1
from utils import weblog, context, interfaces, released, irrelevant, coverage, scenarios, missing_feature, bug
from utils import weblog, context, interfaces, released, irrelevant, coverage, scenarios, missing_feature

if context.weblog_variant in ("akka-http", "spring-boot-payara"):
pytestmark = pytest.mark.skip("missing feature: No AppSec support")
Expand Down Expand Up @@ -173,7 +173,6 @@ def setup_waf_monitoring_errors(self):
self.r_errors = weblog.get("/waf/", params={"v": ".htaccess"})

@scenarios.appsec_rules_monitoring_with_errors
@bug(context.library >= "ruby@1.14.0", reason="Reported error count is 4 instead of 2")
def test_waf_monitoring_errors(self):
"""
Some WAF monitoring span tags and metrics are expected to be sent at
Expand Down