Skip to content

[nodejs] Add test to check absence of client computed stats#4016

Merged
iunanua merged 2 commits intomainfrom
igor/nodejs-absence-client-computed-stats
Feb 11, 2025
Merged

[nodejs] Add test to check absence of client computed stats#4016
iunanua merged 2 commits intomainfrom
igor/nodejs-absence-client-computed-stats

Conversation

@iunanua
Copy link
Contributor

@iunanua iunanua commented Feb 7, 2025

Motivation

Enable Test_AppSecStandalone_NotEnabled test

related #3812

APPSEC-56351

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@iunanua iunanua marked this pull request as ready for review February 7, 2025 10:33
@iunanua iunanua requested a review from a team as a code owner February 7, 2025 10:33
@iunanua iunanua merged commit c4a0eff into main Feb 11, 2025
32 checks passed
@iunanua iunanua deleted the igor/nodejs-absence-client-computed-stats branch February 11, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants