Skip to content

active standalone tests to ensure Datadog-Client-Computed-Stats isn't…#4017

Draft
robertpi wants to merge 2 commits intomainfrom
robert/asm/active-standalone-incident-related-tests
Draft

active standalone tests to ensure Datadog-Client-Computed-Stats isn't…#4017
robertpi wants to merge 2 commits intomainfrom
robert/asm/active-standalone-incident-related-tests

Conversation

@robertpi
Copy link
Member

@robertpi robertpi commented Feb 7, 2025

… sent

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@iunanua
Copy link
Contributor

iunanua commented Feb 7, 2025

I had just enabled it for nodejs this morning
1h before you :P

@robertpi robertpi force-pushed the robert/asm/active-standalone-incident-related-tests branch from ba14232 to 3e1f385 Compare February 21, 2025 09:21
@robertpi robertpi force-pushed the robert/asm/active-standalone-incident-related-tests branch from 71420f3 to 58e5bce Compare February 21, 2025 14:48
@cbeauchesne
Copy link
Collaborator

Seen on slack with @robertpi , still a project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants