Skip to content

Conversation

@bric3
Copy link
Contributor

@bric3 bric3 commented Aug 28, 2025

Motivation

Changes

Related to

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@bric3 bric3 force-pushed the bdu/enable-css-for-java branch from 36c7f2b to c109eef Compare August 28, 2025 15:20
@bric3 bric3 mentioned this pull request Aug 29, 2025
6 tasks
@amarziali amarziali force-pushed the bdu/enable-css-for-java branch from c109eef to 91425d6 Compare September 1, 2025 08:02
@amarziali amarziali marked this pull request as ready for review September 1, 2025 08:34
@amarziali amarziali requested a review from a team as a code owner September 1, 2025 08:34
Copy link
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarziali amarziali force-pushed the bdu/enable-css-for-java branch 2 times, most recently from e965fe7 to 0e1bc2d Compare September 1, 2025 08:56
Copy link
Contributor

@ichinaski ichinaski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@missing_feature(
context.library in ("cpp", "cpp_httpd", "cpp_nginx", "dotnet", "java", "nodejs", "php", "python", "ruby"),
context.library in ("cpp", "cpp_httpd", "cpp_nginx", "dotnet", "nodejs", "php", "python", "ruby")
or context.library <= "java@1.52.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can extract this to a different decorator, to keep this one for all fully unimplemented tracers? I'm not sure what's the most idiomatic way to go about this though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amarziali amarziali force-pushed the bdu/enable-css-for-java branch from d6e90fe to 7840e89 Compare September 2, 2025 08:51
@bric3 bric3 enabled auto-merge (squash) September 2, 2025 13:36
@bric3 bric3 merged commit cca186a into main Sep 2, 2025
1234 of 1237 checks passed
@bric3 bric3 deleted the bdu/enable-css-for-java branch September 2, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants