Skip to content

[APM] Fix CSS test #5170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ichinaski merged 3 commits into from
Aug 29, 2025
Merged

[APM] Fix CSS test #5170

ichinaski merged 3 commits into from
Aug 29, 2025

Conversation

@ichinaski
Copy link
Contributor

@ichinaski ichinaski commented Aug 29, 2025 •
edited
Loading

Motivation

sqlite3 assumption is removed from test_obfuscation, since different languages/weblogs can use different db services.

Changes

  • fix test_obfuscation making it generic for all SDKs

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@ichinaski
[APM] De-skip java from xpassed CSS tests
f015959 
Allow java to run CSS tests for features it has already implemented.

Additionally, sqlite3 assumption is removed from test_obfuscation, since
different languages/weblogs can use different db services.
@ichinaski ichinaski requested a review from a team as a code owner August 29, 2025 10:34
@bric3
Copy link
Contributor

bric3 commented Aug 29, 2025 •
edited
Loading

For readers this relates to

cbeauchesne
cbeauchesne requested changes Aug 29, 2025
View reviewed changes
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@ichinaski ichinaski force-pushed the ichinaski/css-fix-obfuscation-test branch from 114232b to b23b48a Compare August 29, 2025 14:46
@ichinaski ichinaski force-pushed the ichinaski/css-fix-obfuscation-test branch from b23b48a to aad8e76 Compare August 29, 2025 14:52
@ichinaski
Keep java under missing_feature
b600013 
There are several flaky tests still, specially for dev branch
@ichinaski ichinaski changed the title [APM] De-skip java from xpassed CSS tests [APM] Fix CSS test Aug 29, 2025
@ichinaski ichinaski requested a review from cbeauchesne August 29, 2025 15:19
@ichinaski ichinaski enabled auto-merge (squash) August 29, 2025 15:19
@ichinaski ichinaski merged commit f18164d into main Aug 29, 2025
430 checks passed
@ichinaski ichinaski deleted the ichinaski/css-fix-obfuscation-test branch August 29, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3 bric3 bric3 approved these changes

@cbeauchesne cbeauchesne cbeauchesne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ichinaski @bric3 @cbeauchesne