Bump datadog api to v2.18.0 and add support for include units and zero #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gphat
force-pushed
the
cory-update-dd-api-add-yaxis-bits
branch
from
f0b41b7
to
d3c45cc
Compare
|
After running at the acceptance tests, this fails due to the underlying use of |
|
zorkian/go-datadog-api#195 should address the issues zorkian/go-datadog-api#190 introduced along with the legit fix for |
|
zorkian/go-datadog-api#194 was merged, I'm merging this to get your changes and bump the client again to latest in another PR |
|
Wheee, thanks @masci! |
jbenais
pushed a commit
to jbenais/terraform-provider-datadog
that referenced
this pull request
Aug 20, 2019
…s-bits Bump datadog api to v2.18.0 and add support for include units and zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump the datadog API dep to 2.18.0 and add support for
includeZeroandincludeUnits.Motivation
I want units and zeros on my axes! 😺
Notes
The bump also changed Screenboard's width and height so there is perhaps some trouble with the use of strings here. #118 implied this wasn't an ok change to make?
This also fixes #119
Thanks for your consideration!