Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Precision field in Widget *json.Number #194

Merged
merged 2 commits into from
Nov 27, 2018
Merged

Make Precision field in Widget *json.Number #194

merged 2 commits into from
Nov 27, 2018

Conversation

nyanshak
Copy link
Collaborator

  • Make Precision type for Widget match the type for TileDef.

* Make Precision type for Widget match the type for TileDef.
@masci
Copy link

masci commented Nov 15, 2018

Integration tests are exposing the same problem I have, try running

make testacc TESTARGS='-run=TestWidgets'

@nyanshak
Copy link
Collaborator Author

@masci thanks for pushing on this. I'm not sure I'm satisfied with the changes I just pushed, but they DO pass the tests and handle all the various things that could be returned by Datadog.

@zorkian / @yfronto - mind reviewing this?

@masci
Copy link

masci commented Nov 26, 2018

Provided that it's the API acting weird, this patch looks like a good workaround, it's clean and self-contained. @zorkian any chance to get this merged so I can unblock the TF provider release?
Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants