Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #182 - Monitor Tags are not sorted #214

Merged
merged 1 commit into from
May 23, 2019

Conversation

platinummonkey
Copy link
Contributor

Fixes #182 as monitor tags order has no meaning and are not guaranteed to be in the same order

…og/issues/182 as monitor tags order has no meaning and are not guaranteed to be in the same order
@ghost ghost added the size/XS label May 21, 2019
@gzussa gzussa requested review from bkabrda and nmuesch May 21, 2019 13:22
@nmuesch
Copy link
Contributor

nmuesch commented May 23, 2019

Hey @platinummonkey I wasn't able to reproduce the original issue, but it sounds like it wasn't necessarily deterministic. That being said, thanks for this PR, it looks good to me! 🚀

@nmuesch nmuesch merged commit 90631c3 into DataDog:master May 23, 2019
@platinummonkey platinummonkey deleted the monitor-tags-are-not-sorted branch May 23, 2019 12:35
jbenais pushed a commit to jbenais/terraform-provider-datadog that referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource datadog_monitor - Tags always change
2 participants