New data sources for widgets #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jirikuncar
reviewed
Feb 26, 2020
There was a problem hiding this comment.
@roughbits01 can you please extend configs in resource_datadog_timeboard_test.go?
|
@jirikuncar I will 🙂 |
roughbits01
force-pushed
the
marwen.azouzi/security-signals-data-source
branch
2 times, most recently
from
9392358
to
f493ae0
Compare
|
@jirikuncar done :) |
|
Hey @roughbits01, yesterday I merged an update to the latest version of go-datadog-api to master, so when you rebase, everything should start working. Additionally, I'd like to ask you to update the testing cassette for timeboards (a cassette is basically a set of pre-recorded API requests and responses that allows us to test offline and fast). Instructions on how to do this are in README.md. If you have any issues with regenerating the cassette, please let me know and I'll help. Thanks! |
roughbits01
force-pushed
the
marwen.azouzi/security-signals-data-source
branch
from
f493ae0
to
7dcdc70
Compare
|
Hi @bkabrda, I'll update the PR this week 🙂 Thank you for your reply. |
roughbits01
force-pushed
the
marwen.azouzi/security-signals-data-source
branch
from
7dcdc70
to
1c5793b
Compare
therve
force-pushed
the
marwen.azouzi/security-signals-data-source
branch
2 times, most recently
from
5085da3
to
b2e5b7d
Compare
therve
force-pushed
the
marwen.azouzi/security-signals-data-source
branch
from
e32a60f
to
ee55e55
Compare
jirikuncar
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add security signals and RUM events as data sources for Timeseries, Query Value, Table and Top List dashboard widgets.
This PR is related to this go api PR. It will be merged with the version bump after go api PR is merged and a new version is released.