New data sources for widgets #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmuesch
reviewed
Feb 20, 2020
nmuesch
reviewed
Feb 27, 2020
There was a problem hiding this comment.
Thanks, this pretty much looks good to go for me. Sorry for not mentioning it sooner, but could we add a test, maybe similar to https://github.com/zorkian/go-datadog-api/blob/master/integration/dashboards_test.go#L337 that just tries to create these new request types?
nmuesch
reviewed
Mar 2, 2020
| @@ -334,6 +334,68 @@ func createGraphWithLogQuery() []datadog.Graph { | |||
| return graphs | |||
| } | |||
|
|
|||
| func createGraphWithRumQuery() []datadog.Graph { | |||
There was a problem hiding this comment.
Thanks for these. These should be called inside a method Test... similar to
go-datadog-api/integration/dashboards_test.go
Line 134 in f06edcd
nmuesch
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add security signals and RUM events as data sources for Timeseries, Query Value, Table and Top List dashboard widgets.
PS: The terraform-provider-datadog PR