RUM-6120 Upgrade Github action to run on Node.js 20 #173
Conversation
mariedm
force-pushed
the
upgrade-node
branch
from
19a58b8 to
8f60067
Compare
mariedm
force-pushed
the
upgrade-node
branch
from
8f60067 to
9f38ad8
Compare
mariedm
changed the title
mariedm
changed the title
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
src/__tests__/main.test.ts
Outdated
| @@ -24,7 +24,7 @@ describe('Github Action', () => { | |||
| test('with no dsym_paths parameter', async () => { | |||
| // Given | |||
| jest.spyOn(core, 'getInput').mockImplementation(() => 'foo') | |||
| const setFailedMock = jest.spyOn(core, 'setFailed') | |||
| const setFailedMock = jest.spyOn(core, 'setFailed').mockImplementation(() => {}) | |||
There was a problem hiding this comment.
🔴 Code Quality Violation
| const setFailedMock = jest.spyOn(core, 'setFailed').mockImplementation(() => {}) | |
| const setFailedMock = jest.spyOn(core, 'setFailed').mockImplementation(() => {/* empty */}) |
Empty statement. (...read more)
Empty or non-functional blocks in the code can be misleading and lead to maintenance difficulties. They can also lead to a false sense of security or functionality. While they may not directly introduce security issues, their presence can suggest that some logic or error handling is implemented when it is not.
There was a problem hiding this comment.
/nit This suggestion is better than a console call IMHO
mariedm
force-pushed
the
upgrade-node
branch
from
1e8f412 to
d29b3c6
Compare
src/__tests__/main.test.ts
Outdated
| @@ -12,7 +12,10 @@ describe('Github Action', () => { | |||
|
|
|||
| test('with no api_key parameter', async () => { | |||
| // Given | |||
| const setFailedMock = jest.spyOn(core, 'setFailed') | |||
| const setFailedMock = jest.spyOn(core, 'setFailed').mockImplementation((message) => { | |||
| console.log(`Mocked setFailed called with message: ${message}`); | |||
There was a problem hiding this comment.
🟠 Code Quality Violation
Unexpected console statement. (...read more)
Debugging with console is not considered a bad practice, but it's easy to forget about console statements and leave them in production code. There is no need to pollute production builds with debugging statements.
src/__tests__/main.test.ts
Outdated
| @@ -24,7 +27,10 @@ describe('Github Action', () => { | |||
| test('with no dsym_paths parameter', async () => { | |||
| // Given | |||
| jest.spyOn(core, 'getInput').mockImplementation(() => 'foo') | |||
| const setFailedMock = jest.spyOn(core, 'setFailed') | |||
| const setFailedMock = jest.spyOn(core, 'setFailed').mockImplementation((message) => { | |||
| console.log(`Mocked setFailed called with message: ${message}`); | |||
There was a problem hiding this comment.
🟠 Code Quality Violation
Unexpected console statement. (...read more)
Debugging with console is not considered a bad practice, but it's easy to forget about console statements and leave them in production code. There is no need to pollute production builds with debugging statements.
src/__tests__/main.test.ts
Outdated
| const setFailedMock = jest.spyOn(core, 'setFailed') | ||
| /* eslint-disable no-console */ | ||
| const setFailedMock = jest.spyOn(core, 'setFailed').mockImplementation((message) => { | ||
| console.log(`Mocked setFailed called with message: ${message}`) |
There was a problem hiding this comment.
🟠 Code Quality Violation
Unexpected console statement. (...read more)
Debugging with console is not considered a bad practice, but it's easy to forget about console statements and leave them in production code. There is no need to pollute production builds with debugging statements.
mariedm
force-pushed
the
upgrade-node
branch
2 times, most recently
from
949aeeb to
c46e789
Compare
mariedm
force-pushed
the
upgrade-node
branch
from
c46e789 to
d24c944
Compare
mariedm
changed the title
This PR updates the repository to use Node.js 20 in alignement with GitHub’s recent transition to Node.js 16 for GitHub Actions.
Given that we were already using Node.js 18 in the dependencies, and that Github Action doesn't support Node.js 18, it made sense to move directly to Node.js 20.