Skip to content

Conversation

@peyronth
Copy link
Contributor

No description provided.

@peyronth peyronth requested review from Copilot and gballigand June 20, 2025 10:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates multiple component usages from FSClickable to FSCard across the shared and core component libraries, ensuring consistency with the new design guidelines. Key changes include updating component imports and template usages, revising prop types and variants (e.g., for chips, cards, and buttons), and reflecting these adjustments in storybook examples.

Reviewed Changes

Copilot reviewed 20 out of 33 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/shared/foundation-shared-components/components/FSPlayButtons.vue Replaces FSClickable with FSCard for play button actions.
src/shared/foundation-shared-components/components/FSOptionsMenu.vue Uses FSCard instead of FSClickable with updated color and variant props.
src/shared/foundation-shared-components/components/FSChip.vue Updates slot syntax and expands alignment options in FSChip.
src/shared/foundation-core-components/components/lists/dataDefinitions/FSBaseDataDefinitionsList.vue Adjusts card variant logic for selection state handling.
dev/storybook/* Updates story files to reflect new FSCard usage and correct prop bindings.
Comments suppressed due to low confidence (5)

src/shared/foundation-shared-components/components/FSClickable.vue:57

  • Ensure that the deprecation warning here is also reflected in the component's public documentation and guides to aid migration.
    });

src/shared/foundation-shared-components/components/FSChip.vue:109

  • Ensure that all consumers of FSChip are updated to accommodate the expanded alignment options and verify that the new default value ('center-center') produces the intended layout.
    }

src/core/foundation-core-components/components/lists/dataDefinitions/FSBaseDataDefinitionsList.vue:35

  • Confirm that replacing conditional color logic with a fixed color + variant change meets the design requirements for indicating selection state, ensuring expected visual cues are maintained.
        :color="ColorEnum.Primary"

src/shared/foundation-shared-components/components/FSCard.vue:315

  • Verify that the set of pointer event handlers provided in wrapperListeners covers all required interactive behaviors to ensure consistent clickable functionality, and consider adding unit tests for edge cases.
          mouseover: () => { hover.value = true },

src/shared/foundation-shared-components/components/FSButton.vue:119

  • Verify that the computed 'iconVariantColor' returns the correct color for FSButton icon elements under different states, so that icon colors remain consistent with design expectations.
          :color="iconVariantColor"

@peyronth peyronth marked this pull request as ready for review June 24, 2025 10:23
@peyronth peyronth removed the request for review from SchroterQuentin July 21, 2025 06:57
@peyronth peyronth requested review from dimitrilexi and gballigand and removed request for gballigand July 21, 2025 06:57
@@ -0,0 +1,7 @@
export type CardVariant = "background" | "standard" | "full" | "gradient";
export enum CardVariants {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les enums dans le dossier foundation-shared-domain/enums

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants