-
Notifications
You must be signed in to change notification settings - Fork 0
Update/fs card #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update/fs card #623
Conversation
This reverts commit 95d5213.
…nd update styles accordingly
Update/fs card
…ponent to navigate through app, website or listen click events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates multiple component usages from FSClickable to FSCard across the shared and core component libraries, ensuring consistency with the new design guidelines. Key changes include updating component imports and template usages, revising prop types and variants (e.g., for chips, cards, and buttons), and reflecting these adjustments in storybook examples.
Reviewed Changes
Copilot reviewed 20 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/shared/foundation-shared-components/components/FSPlayButtons.vue | Replaces FSClickable with FSCard for play button actions. |
| src/shared/foundation-shared-components/components/FSOptionsMenu.vue | Uses FSCard instead of FSClickable with updated color and variant props. |
| src/shared/foundation-shared-components/components/FSChip.vue | Updates slot syntax and expands alignment options in FSChip. |
| src/shared/foundation-core-components/components/lists/dataDefinitions/FSBaseDataDefinitionsList.vue | Adjusts card variant logic for selection state handling. |
| dev/storybook/* | Updates story files to reflect new FSCard usage and correct prop bindings. |
Comments suppressed due to low confidence (5)
src/shared/foundation-shared-components/components/FSClickable.vue:57
- Ensure that the deprecation warning here is also reflected in the component's public documentation and guides to aid migration.
});
src/shared/foundation-shared-components/components/FSChip.vue:109
- Ensure that all consumers of FSChip are updated to accommodate the expanded alignment options and verify that the new default value ('center-center') produces the intended layout.
}
src/core/foundation-core-components/components/lists/dataDefinitions/FSBaseDataDefinitionsList.vue:35
- Confirm that replacing conditional color logic with a fixed color + variant change meets the design requirements for indicating selection state, ensuring expected visual cues are maintained.
:color="ColorEnum.Primary"
src/shared/foundation-shared-components/components/FSCard.vue:315
- Verify that the set of pointer event handlers provided in wrapperListeners covers all required interactive behaviors to ensure consistent clickable functionality, and consider adding unit tests for edge cases.
mouseover: () => { hover.value = true },
src/shared/foundation-shared-components/components/FSButton.vue:119
- Verify that the computed 'iconVariantColor' returns the correct color for FSButton icon elements under different states, so that icon colors remain consistent with design expectations.
:color="iconVariantColor"
…e with FSRouterLink and update props handling
… link set its own href
| @@ -0,0 +1,7 @@ | |||
| export type CardVariant = "background" | "standard" | "full" | "gradient"; | |||
| export enum CardVariants { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Les enums dans le dossier foundation-shared-domain/enums
No description provided.