Contact Ended System Overhaul #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CollisionEnded renamed to ContactEnded - New Contact class added -
- OnContactEnded event fixed - OnColliderContact event fixed - ResolveContactEnded function implemented - ResolveColliderContactEnded function implemented
… info from List<CollisionInformation> info. - CollisionHandler updated. - EndlessSpaceCollision scene updated. - GameObjectHandlerExample scene updated.
…invalid collision points
…onPoint renamed to GetCombinedCollisionPoint in Collision.
…ads) added to CollisionInformation. Exists, Find, FindAll functions added to CollisionInformation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Contact Ended system was lacking functionality and did not work correctly after the 3.0 changes to how collision information is collected. I have split the system in 2 systems:
Each individual collision / overlap between two colliders reports FirstContact and Contact ended. In addition to that CollisionObjects now report FirstContact and Contact ended as well. If two collision objects contact for the first time (with any pair of colliders) FirstContact within the resulting CollisionInformation will be true. As soon as all contacts between those two collision objects have ended, ContactEnded() will be called on the active collision object.
Previously, this was not possible on the user side because only colliders reported FirstContact/ ContactEnded without anything taking CollisionObjects into account. So if a collider reported ContactEnded, it was still possible that another pair of colliders between the same collision objects was still in contact.