Fix to do dispatch agent if mapped scene is not active when launching autopilot #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo40
reviewed
Oct 21, 2024
Runtime/Autopilot.cs
Outdated
| @@ -8,9 +8,11 @@ | |||
| using DeNA.Anjin.Loggers; | |||
| using DeNA.Anjin.Settings; | |||
| using DeNA.Anjin.Utilities; | |||
| using UnityEditor; | |||
There was a problem hiding this comment.
[ASK]
Maybe #if UNITY_EDITOR ... #endif symbol guard is necessary?
There was a problem hiding this comment.
Thanks! fix in 95acd36
|
I will rebase after revert 6352869 |
… autopilot Situation: Launch autopilot while in play mode, or player build. And multiple scenes are loaded, but the scene the agent is mapped to is not active (it is loaded). Problem: Did not dispatch agent mapped to a loaded scene. Fixes: Check mapping all loaded scenes if active scene is not mapped on launch.
nowsprinting
force-pushed
the
fix/agent_dispatch_on_launch
branch
from
6352869
to
f2d5f9f
Compare
1 task
|
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Situation
Launch autopilot while in play mode or running player build.
Multiple scenes are loaded, but the scene the agent is mapped to is not active (it is loaded).
Actual
Did not dispatch agent.
Expected
Dispatch agent mapped in the loaded (not active) scene.
Fixes
Check mapping all loaded scenes if active scene is not mapped on launch.
Priority
I want it to be released at the same time as #76
Contribution License Agreement