Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support run on player build [experimental] #76

Merged
merged 21 commits into from
Oct 28, 2024
Merged

Support run on player build [experimental] #76

merged 21 commits into from
Oct 28, 2024

Conversation

nowsprinting
Copy link
Contributor

Overview

Added support for running player builds.
It is needed for performance testing, aging, etc.

It's still unfriendly and time-consuming.
So, I've made it an experimental feature.

Please see the README for the differences in specifications.

Main changes

  • Fix to Launcher to run on the player build
    • Fix tests run on player
    • Refactor around launch/terminate
  • Fix file output path on the player
  • Add command line argument for launch autopilot on player

Chores, fix bugs

  • Fix survive agents after terminate
  • Fix reset trigger on OneTimeAgent
  • Fix InitializeOnLaunchAutopilotAttribute inherit PreserveAttribute
  • Fix tests
  • Fix READMEs
  • Remove not used asset files

Priority

I'd want it to be released within 1 to 2 weeks.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner October 19, 2024 21:48
@nowsprinting nowsprinting mentioned this pull request Oct 20, 2024
Merged
1 task
@nowsprinting
Copy link
Contributor Author

I will rebase this PR after the merge #77

@nowsprinting nowsprinting marked this pull request as draft October 22, 2024 05:32
@nowsprinting nowsprinting force-pushed the feature/run_on_player branch from fa09285 to 50b3e33 Compare October 22, 2024 06:16
@nowsprinting nowsprinting marked this pull request as ready for review October 22, 2024 06:24
@nowsprinting
Copy link
Contributor Author

rebased!

@get-me-power get-me-power requested review from bo40 and asurato October 24, 2024 09:22
bo40
bo40 previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few minor comments.
Overall, it looks good to me.

@nowsprinting nowsprinting requested a review from bo40 October 25, 2024 20:44
bo40
bo40 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40 bo40 merged commit 9c0afcb into DeNA:master Oct 28, 2024
1 check passed
@bo40
Copy link
Contributor

bo40 commented Oct 28, 2024

Once #83 and #85 are merged, we plan to release this feature as v1.7.0.

@nowsprinting nowsprinting deleted the feature/run_on_player branch October 28, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo40 bo40 bo40 approved these changes

@asurato asurato Awaiting requested review from asurato

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @bo40