Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod README, add a general policy for accepting/rejecting new features. #83

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

  • Fix wording
  • Add a general policy for accepting/rejecting new features.

The general policy is just my idea.
If necessary, I would like to discuss.


Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner October 22, 2024 09:12
@github-actions github-actions bot added the chore label Oct 22, 2024
README.md Outdated

A Reporter that post report to Slack.

The instance of this Reporter (.asset file) can have the following settings.

<dl>
<dt>Slack Token</dt><dd>Web API token used for Slack notifications. If omitted, no notifications will be sent.
<dt>Slack Token</dt><dd>Oath token of Slack Bot used for notifications. If omitted, no notifications will be sent.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think thai it is OAuth token

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! fixed in f45f022

Copy link
Member

@get-me-power get-me-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@get-me-power get-me-power merged commit 06485b3 into DeNA:master Oct 28, 2024
1 check passed
@get-me-power
Copy link
Member

@nowsprinting

Thanks for your contribution.

@nowsprinting nowsprinting deleted the chore/mod_readme branch October 28, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants