Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sg 1041 rename object names #1446

Merged
merged 26 commits into from
Sep 19, 2023
Merged

Feature/sg 1041 rename object names #1446

merged 26 commits into from
Sep 19, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Sep 3, 2023 •
edited
Loading

How the deprecation looks

/home/louis.dupont/PycharmProjects/super-gradients/src/super_gradients/common/registry/registry.py:72: DeprecationWarning: Object name `cross_entropy` is now deprecated. Please replace it with `LabelSmoothingCrossEntropyLoss`.
  warnings.warn(f"Object name `{name}` is now deprecated. Please replace it with `{deprecated_names[name]}`.", DeprecationWarning)
/home/louis.dupont/PycharmProjects/super-gradients/src/super_gradients/common/registry/registry.py:72: DeprecationWarning: Object name `linear_epoch_step` is now deprecated. Please replace it with `EpochStepWarmupLRCallback`.
  warnings.warn(f"Object name `{name}` is now deprecated. Please replace it with `{deprecated_names[name]}`.", DeprecationWarning)

The number of file changed may be intimidating, but it is relatively fast to review (took me 5 minutes), you just need to compare a lot of before/after and make sure the names are "similar'

Breaking change failed. Require #1458 to be merged

@Louis-Dupont Louis-Dupont mentioned this pull request Sep 3, 2023
Merged
@Louis-Dupont Louis-Dupont marked this pull request as ready for review September 4, 2023 12:17
@Louis-Dupont Louis-Dupont marked this pull request as draft September 5, 2023 13:22
@Louis-Dupont Louis-Dupont marked this pull request as ready for review September 11, 2023 20:17
ofrimasad
ofrimasad approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit 1b558ed into master Sep 19, 2023
3 checks passed
@shaydeci shaydeci deleted the feature/SG-1041-rename_object_names branch September 19, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci

@BloodAxe BloodAxe Awaiting requested review from BloodAxe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Louis-Dupont @ofrimasad @shaydeci @BloodAxe