Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Breaking Change Detection on Inheritence #1458

Merged

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Sep 12, 2023

Context

Let's imagine we change the code

FROM

class MyClass:
    def method(self): pass

TO

class MyNewClass:
    def method(self): pass

class MyClass(MyNewClass): pass

This is NOT a breaking change, because MyClass inherits from MyNewClass which still includes method.

Issue: current class signature extractor (implemented as part of the breaking change detection) currently misses this and will raise that the new MyClass does not include method.

@Louis-Dupont Louis-Dupont marked this pull request as ready for review September 12, 2023 07:50
BloodAxe
BloodAxe previously approved these changes Sep 18, 2023
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit 61f46e3 into master Sep 18, 2023
3 checks passed
@Louis-Dupont Louis-Dupont deleted the hotfix/SG-000-fix_breaking_change_detection_on_inheritence branch September 18, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants