Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Typing Shim #1

Open
wants to merge 2,357 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
2357 commits
Select commit Hold shift + click to select a range
72233f0
Wooooo tests
Happypig375 Jun 13, 2021
e3c70ed
LangVersion test
Happypig375 Jun 13, 2021
1b7bbf8
Add one more test
Happypig375 Jun 13, 2021
ef0d40b
As 16 to 18 are WIP
Happypig375 Jun 14, 2021
ae1900d
Destroy "1 | 2 as :? int"
Happypig375 Jun 14, 2021
a56ff5a
Slap a net472 ignore
Happypig375 Jun 14, 2021
e1c785d
Eliminate tuple allocations in branching let binding rhs (#11407)
kerams Jun 16, 2021
f13b4ff
`ByteBuffer` uses `ArrayPool` to prevent LOH allocations (#11660)
TIHan Jun 16, 2021
1e750b3
Stop incremental builder from accumulating TcSymbolUses/TcResolutions…
TIHan Jun 16, 2021
0d2f666
Fix IL test after merging tuple elimination feature
vzarytovskii Jun 17, 2021
b443d1d
Merge pull request #11685 from vzarytovskii/fix-test-in-main
dsyme Jun 17, 2021
e298ca1
fix boxing promotion for locally mutable values
Jun 17, 2021
baa112d
add test
Jun 17, 2021
2798914
reduce fix
Jun 17, 2021
405b16f
simplify fix
Jun 17, 2021
ad53eb7
simplify fix
Jun 17, 2021
1c8ddd6
add test
Jun 17, 2021
b13a2b1
fix generated names in release code
Jun 17, 2021
b7cdca8
update baseline for improved names
Jun 17, 2021
01be658
Merge pull request #11690 from dsyme/r3
dsyme Jun 17, 2021
ea673de
Consolidating Roslyn workspace and FCS
TIHan Jun 18, 2021
ba1a55c
Added WorkspaceExtensions
TIHan Jun 18, 2021
5780674
More cleanup. Trying to fix tests.
TIHan Jun 19, 2021
bf3e19e
Optimize TryRewriteBranchingTupleBinding (#11698)
kerams Jun 21, 2021
db79435
Fixing IsFSharp
TIHan Jun 21, 2021
90aba6e
[main] Update dependencies from dotnet/arcade (#11693)
dotnet-maestro[bot] Jun 21, 2021
68066a2
Turn on loc PRs
jonfortescue Jun 21, 2021
dbdc77d
Got mef to almost work in testing
TIHan Jun 21, 2021
2809166
More cleanup
TIHan Jun 21, 2021
b639ae6
Merge pull request #11702 from jonfortescue/TurnOnLocPrs
brettfo Jun 22, 2021
ea35671
cleanup
TIHan Jun 22, 2021
f9c0c6e
minor cleanup
TIHan Jun 22, 2021
5c96c82
Added IFSharpVisualStudioService
TIHan Jun 22, 2021
95492d6
Some tests are passing. Removed use of EditorOptions in CheckerProvid…
TIHan Jun 22, 2021
241dc4a
cleanup
TIHan Jun 22, 2021
df62bdc
Localized file check-in by OneLocBuild Task (#11708)
dotnet-bot Jun 22, 2021
94af3d7
[main] Update dependencies from dotnet/arcade (#11707)
dotnet-maestro[bot] Jun 22, 2021
4014bec
Added Project extensions to get editor options
TIHan Jun 22, 2021
7b553df
Merge remote-tracking branch 'remote/main' into vs-consolidation
TIHan Jun 22, 2021
84d033c
Simplifying
TIHan Jun 22, 2021
97a3300
Removing all importing of FSharpProjectOptionsManager. Removed mocks …
TIHan Jun 22, 2021
f0dfcd1
Uncomment
TIHan Jun 22, 2021
efd7e75
Trying to fix build
TIHan Jun 22, 2021
41481f7
SyntaxTree: introduce SynTyparDeclList
auduchinok Jun 21, 2021
434c6f0
Update surface area
auduchinok Jun 22, 2021
3cbb272
Update constraints usages in patterns
auduchinok Jun 22, 2021
c24f559
Fix duplicate constraints
auduchinok Jun 22, 2021
1bb9cbc
Some refactoring
TIHan Jun 22, 2021
524fa8d
Make this internal
TIHan Jun 22, 2021
afce9ed
Forgot the importing constructor
TIHan Jun 22, 2021
27f44be
More refactoring
TIHan Jun 22, 2021
bc96749
Fixed completion service
TIHan Jun 22, 2021
ec59ec0
fixing tests
TIHan Jun 22, 2021
2105321
Trying to fix tests
TIHan Jun 22, 2021
69b923a
Another test fix
TIHan Jun 22, 2021
59f1fd7
More cleanup
TIHan Jun 22, 2021
4bd16d6
fixing tests
TIHan Jun 22, 2021
6ce8051
Merge pull request #11674 from Happypig375/patch-6
dsyme Jun 23, 2021
9b3846c
Merge pull request #10867 from auduchinok/synTyparDeclList
dsyme Jun 23, 2021
6911767
Update package versions (#11712)
KevinRansom Jun 23, 2021
19ade78
[main] Update dependencies from dotnet/arcade (#11714)
dotnet-maestro[bot] Jun 23, 2021
2581da7
Stop switching to threadpool
TIHan Jun 23, 2021
2050e32
Feedback changes
TIHan Jun 23, 2021
794ce49
SyntaxTree: add Range to SynSimplePat, SynSimplePats, SynTypeConstrai…
auduchinok Jun 24, 2021
7fee771
Merge pull request #11715 from TIHan/vs-threadpool-fix
dsyme Jun 24, 2021
48e06db
Merge pull request #11694 from TIHan/vs-consolidation
dsyme Jun 24, 2021
277357d
Merge remote-tracking branch 'remote/main' into vs-script-fixes
TIHan Jun 24, 2021
4697480
Fixing build
TIHan Jun 24, 2021
c48e078
Fix the YAML indent for OneLocBuild template (#11711)
jonfortescue Jun 24, 2021
682c4c0
Added DocumentInfo/ProjectInfo CreateFSharp extension
TIHan Jun 24, 2021
ed34c05
Uncomment
TIHan Jun 24, 2021
45c7887
minor cleanup
TIHan Jun 24, 2021
06d35a6
Reverting ProjectInfo/DocumentInfo additions
TIHan Jun 24, 2021
fa5d334
Minor change
TIHan Jun 24, 2021
c88dcb0
Minor revert
TIHan Jun 24, 2021
c24e14a
Added IFSharpWorkspaceProjectContext and IFSharpWorkspaceProjectConte…
TIHan Jun 24, 2021
634b7d9
Added basic misc file workspace test
TIHan Jun 24, 2021
3148886
First workspace script test done
TIHan Jun 24, 2021
bc96ed8
Added tests for scripts referencing scripts
TIHan Jun 24, 2021
10002a3
Minor fix
TIHan Jun 25, 2021
494a2d2
Minor fix
TIHan Jun 25, 2021
7df1647
Minor fix
TIHan Jun 25, 2021
ebe1770
Disable two flakey tests
TIHan Jun 25, 2021
1726c41
Merge pull request #11726 from TIHan/disable-two-tests
dsyme Jun 25, 2021
a891d06
Merge pull request #11643 from TIHan/vs-script-fixes
dsyme Jun 25, 2021
8984266
Localized file check-in by OneLocBuild Task (#11728)
dotnet-bot Jun 26, 2021
ec83cf9
Localized file check-in by OneLocBuild Task (#11727)
dotnet-bot Jun 26, 2021
f84927a
Include range of attributes in extern declaration. (#11736)
nojaf Jun 28, 2021
52130f8
Define ParsedHashDirective arguments as ParsedHashDirectiveArgument i…
nojaf Jun 28, 2021
095deb3
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jun 28, 2021
23004bc
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jun 28, 2021
784c7ad
use path separator instead of hardcoded semicolon (#11730)
baronfel Jun 28, 2021
ec3323b
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jun 28, 2021
0039756
Merge pull request #11465 from pezipink/quotation_race
dsyme Jun 29, 2021
4378143
Optimize interpolated string with no holes (#11632)
kerams Jun 29, 2021
8339418
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jun 29, 2021
2f3c057
[main] Update dependencies from dotnet/arcade (#11720)
dotnet-maestro[bot] Jun 29, 2021
bd862b8
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jun 29, 2021
4157807
Add FSC option for retrieving raw lexer tokens (#10578)
laenas Jun 29, 2021
07382fb
Allow attributes after the 'module' keyword (#11722)
Happypig375 Jun 29, 2021
698f1c1
Localized file check-in by OneLocBuild Task (#11747)
dotnet-bot Jun 29, 2021
76911eb
Added script reference test and clearing check file caches on re-crea…
TIHan Jun 29, 2021
6deea74
minor fix of duplicate definition in ServiceLexing.fsi (#11756)
goswinr Jun 30, 2021
f938c0c
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jun 30, 2021
692eaa4
fix 11620 (#11755)
dsyme Jul 1, 2021
494c5a4
Localized file check-in by OneLocBuild Task (#11766)
dotnet-bot Jul 1, 2021
9cbbf4c
Improve debugging of retail and inline code by not erasing locals and…
dsyme Jul 2, 2021
a85aac5
Add internal `block` type for use in the compiler. `IncrementalBuilde…
TIHan Jul 2, 2021
1ed872e
Localized file check-in by OneLocBuild Task (#11774)
dotnet-bot Jul 2, 2021
6cb608f
Localized file check-in by OneLocBuild Task (#11773)
dotnet-bot Jul 2, 2021
5cfd7ff
Localized file check-in by OneLocBuild Task (#11768)
dotnet-bot Jul 2, 2021
dfeb8a9
apply source-build patches (#11762)
brettfo Jul 3, 2021
d48369f
Use RunImmediate for better debug stacks (#11788)
dsyme Jul 6, 2021
a940bd5
Fix 11771 - cross-project references for projects using generative ty…
dsyme Jul 7, 2021
8c6df9c
Revert "Improve debugging of retail and inline code by not erasing lo…
dsyme Jul 7, 2021
5148e8d
Remove call to SetLength (#11796)
TIHan Jul 8, 2021
78ca728
Add RequireQualifiedAccess to ParsedHashDirectiveArgument type. (#11795)
nojaf Jul 8, 2021
33f7e88
Fix 11797 (#11799)
dsyme Jul 8, 2021
3bc3870
RunImmediate should use RunSynchronously if called on UI thread (#11805)
dsyme Jul 8, 2021
43f27c6
Correct body SynExpr of parsedData of Lambda when wildcards are invol…
nojaf Jul 9, 2021
8cce324
Cleanup and document async.fs (#11806)
dsyme Jul 9, 2021
07f156e
update System.Net.Security package from 4.3.0 to 4.3.1 (#11810)
brettfo Jul 9, 2021
5af4584
Warn unsupported attributes (#11812)
Happypig375 Jul 12, 2021
91925a4
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jul 12, 2021
a038c6f
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jul 12, 2021
99b40af
Add link to FCS preview versions (#11760)
nojaf Jul 12, 2021
a90f0f0
Update base directory probing (#11824)
KevinRansom Jul 13, 2021
e5920c1
Simplify FCS SurfaceAreaTest test (#11574)
smoothdeveloper Jul 13, 2021
b4ba6f7
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jul 13, 2021
6dd7131
Additional intrinsics for the NativePtr module (#11682)
Happypig375 Jul 13, 2021
eb8ff02
Update F# Compiler Technical Guide link (#11830)
nojaf Jul 14, 2021
95ed428
Fix ranges of function applications in Release code (#11827)
dsyme Jul 14, 2021
3d9eb5a
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jul 14, 2021
995989a
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jul 14, 2021
66879ee
[main] Update dependencies from dotnet/arcade (#11753)
dotnet-maestro[bot] Jul 14, 2021
3fd4c27
Fix tailcalls in async.fs (#11820)
dsyme Jul 14, 2021
5f24c09
[main] Update dependencies from dotnet/arcade (#11834)
dotnet-maestro[bot] Jul 15, 2021
fca1cd7
Minor test namespace refactor (#11836)
KevinRansom Jul 16, 2021
4f826ec
[main] Update dependencies from dotnet/arcade (#11838)
dotnet-maestro[bot] Jul 16, 2021
e19155e
Fix races in the ProvidedTypesContext (#11841)
DedSec256 Jul 16, 2021
f45ef81
[RFC FS-1087, FS-1097, FS-1098] tasks, resumable state machines, inli…
dsyme Jul 19, 2021
bd1c722
Fix test failure in main (due to namespace change) (#11850)
vzarytovskii Jul 19, 2021
cb6225a
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jul 19, 2021
187b5d5
Return Fsc command line args from CoreCompile (#11846)
baronfel Jul 19, 2021
4fc219e
[main] Update dependencies from dotnet/arcade (#11845)
dotnet-maestro[bot] Jul 19, 2021
7ce3247
Cleanup: remove redundant parens (#11857)
auduchinok Jul 21, 2021
1dbbd55
Cleanup: redundant union case field patterns (#11860)
auduchinok Jul 21, 2021
e3b9b45
Restore spell checker dictionary (#11855)
auduchinok Jul 21, 2021
001cbd6
Cleanup: remove redundant qualifiers (#11859)
auduchinok Jul 21, 2021
9a13dbb
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jul 21, 2021
9d4fb7d
[main] Update dependencies from dotnet/arcade (#11854)
dotnet-maestro[bot] Jul 21, 2021
a7a47cf
Cleanup: remove redundant 'new' (#11858)
auduchinok Jul 21, 2021
7250a7e
Cleanup: attributes (#11867)
auduchinok Jul 21, 2021
8a62ed9
Cleanup: remove unused opens (#11856)
auduchinok Jul 21, 2021
edeb974
Added basic F# notebook for benchmarking (#11870)
TIHan Jul 22, 2021
d6fba3a
More cleanup (#11869)
auduchinok Jul 22, 2021
11d81ea
Extend SynExpr.IfThenElse with keyword information. (#11835)
nojaf Jul 23, 2021
212f9f8
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jul 23, 2021
0df3819
localization (#11880)
KevinRansom Jul 25, 2021
b856984
GetTempFile() (#11853)
KevinRansom Jul 25, 2021
32d8989
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jul 26, 2021
786714e
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Jul 26, 2021
b831e4f
[main] Update dependencies from dotnet/arcade (#11882)
dotnet-maestro[bot] Jul 27, 2021
8169f2c
Use net6 previews for building (#11545)
vzarytovskii Aug 4, 2021
78c146d
Remove Visual Studio Online (#11913)
ShalokShalom Aug 4, 2021
6f7e2a0
Check qualifier reported types after filtering errors (#11909)
auduchinok Aug 4, 2021
a785d0b
Add missing _SetPathMapFromSourceRoots target from Roslyn (#11921)
baronfel Aug 9, 2021
f767719
RFC FS-1108 - Allow more undentations and remove inconsistencies (#11…
Happypig375 Aug 9, 2021
7b7965a
cleanup renaming (#11937)
dsyme Aug 9, 2021
d4370dc
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Aug 9, 2021
ba10b68
Renamed global.json in manual tests, as it messes up with AzDO Pipeli…
vzarytovskii Aug 9, 2021
3a610e0
Add arrow range to SynExpr.Lambda and SynMatchClause (#11905)
nojaf Aug 10, 2021
3b0e1b7
fix async task completion on UI thread (#11947)
dsyme Aug 10, 2021
15a7c32
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Aug 11, 2021
38caa24
Fix 9369 - index setters with param array (#11942)
dsyme Aug 12, 2021
1560dbc
minor typo in docstring cref (#11956)
goswinr Aug 12, 2021
1a30c19
Set NonParallelizable on tests assembly (#11917)
KevinRansom Aug 12, 2021
96e1782
second part of #11755 (#11763)
dsyme Aug 12, 2021
a717e53
[RFC FS-1113] Additions to collection functions (#11888)
uxsoft Aug 12, 2021
6855e5b
Don't store TcGlobals in FSharpSymbolUse (#11932)
auduchinok Aug 12, 2021
d5cc116
[RFC FS-1093] Additional type directed conversions (#10884)
dsyme Aug 13, 2021
4049ab6
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Aug 13, 2021
34d4ede
Add Instantiation to FSharpSymbolUse (#11934)
auduchinok Aug 13, 2021
a7cc3bb
don't use 'abs' in hash codes (#11965)
dsyme Aug 14, 2021
f1d420b
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Aug 14, 2021
d70f4ab
Array.skip does not fail on negativ count, updated docstring (#11975)
goswinr Aug 17, 2021
0b2c732
add comments and tests of keys and values order (#11974)
uxsoft Aug 17, 2021
ffbc0d4
Fix #11962 - Build VisualFSharp.sln fails with FSharpEmbedResXSource …
KevinRansom Aug 17, 2021
7281c70
[Experiment] Pin sdk version for plain build + build service solution…
vzarytovskii Aug 17, 2021
dc6cd9d
[main] Update dependencies from dotnet/arcade (#11902)
dotnet-maestro[bot] Aug 17, 2021
55df161
[main] Update dependencies from dotnet/arcade (#11984)
dotnet-maestro[bot] Aug 17, 2021
10d5ef2
Breakpoints on pipeline stages (#11957)
dsyme Aug 17, 2021
6b6c78c
List.skip does not fail on negative count (#11983)
goswinr Aug 17, 2021
3b16e05
Install both latest public and latest stable SDKs. Check that solutio…
vzarytovskii Aug 18, 2021
9d92884
[main] Update dependencies from dotnet/arcade (#11990)
dotnet-maestro[bot] Aug 18, 2021
ac2ce91
Fix some debug glitches (#11981)
dsyme Aug 18, 2021
ef4474f
Update PatternMatchCompilation.fs (#11992)
dsyme Aug 19, 2021
63ec4ae
[main] Update dependencies from dotnet/arcade (#11995)
dotnet-maestro[bot] Aug 19, 2021
56d0cf4
[main] Update dependencies from dotnet/arcade (#11999)
dotnet-maestro[bot] Aug 20, 2021
d83c79f
Change default scripting to NetSDK (#11997)
KevinRansom Aug 20, 2021
2342809
[main] Update dependencies from dotnet/arcade (#12008)
dotnet-maestro[bot] Aug 21, 2021
69f4495
Additions to immutable collections - Added examples in xmldoc (#12007)
uxsoft Aug 22, 2021
699291a
[RFC FS-1110, 1111] index syntax and ref cell op deprecation (#11900)
dsyme Aug 23, 2021
2cd5b65
Syntax tree: produce attributes without owner (#12014)
auduchinok Aug 23, 2021
3b0376b
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Aug 23, 2021
a365b05
Cleanup and preparatory work for adding 'open' declarations to inform…
dsyme Aug 23, 2021
9ac9243
[CompilerPerf] Added benchmark comparisons of older versions of FShar…
TIHan Aug 24, 2021
a31c18e
fix regression in debug codegen (#12021)
dsyme Aug 24, 2021
ceb2fd0
Update release-notes.md (#12024)
dsyme Aug 24, 2021
664dd97
update docstring: line<>column (#12032)
goswinr Aug 24, 2021
185ddc8
fix #12025, fix a case where wrong warning was reported for a method …
dsyme Aug 24, 2021
99b296b
Fix 7456, 3704, 12019 (debug scopes, self arg, incorrect information …
dsyme Aug 25, 2021
92bc169
[main] Update dependencies from dotnet/arcade (#12036)
dotnet-maestro[bot] Aug 25, 2021
e049864
skip flaky test
brettfo Aug 26, 2021
0fa76f2
[main] Update dependencies from dotnet/arcade (#12041)
dotnet-maestro[bot] Aug 26, 2021
ef6651c
[main] Update dependencies from dotnet/arcade (#12050)
dotnet-maestro[bot] Aug 27, 2021
d724af2
Parser: fix range for missing lambda body arb expression (#12015)
auduchinok Aug 27, 2021
208aff8
Prevent inaccessible members from appearing in tooltips (#12048)
TIHan Aug 28, 2021
33033f5
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Aug 30, 2021
1d7d97e
Prevent inaccessible members from being generated for a signature (#1…
TIHan Aug 30, 2021
38f966d
Parser: add recovery for unfinished match clauses (#10872)
auduchinok Aug 30, 2021
ddfd56f
[main] Update dependencies from dotnet/arcade (#12057)
dotnet-maestro[bot] Aug 31, 2021
df59876
[main] Update dependencies from dotnet/arcade (#12087)
dotnet-maestro[bot] Sep 2, 2021
efeb98e
Fix embedded PDB support on big-endian systems (#12086)
uweigand Sep 2, 2021
791d4dd
Fix 12085 (#12095)
dsyme Sep 2, 2021
64b3354
Parser: better tree for unfinished paren patterns (#12065)
auduchinok Sep 2, 2021
2d4cc88
[main] Update dependencies from dotnet/arcade (#12101)
dotnet-maestro[bot] Sep 3, 2021
b3d46d4
Printing updates (#12072)
dsyme Sep 3, 2021
c88b795
[RFC FS-1114] Make long-established deprecation warning messages into…
dsyme Sep 5, 2021
e2868d9
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Sep 6, 2021
e1259cb
[main] Update dependencies from dotnet/arcade (#12112)
dotnet-maestro[bot] Sep 6, 2021
a836fb7
Enable parallelism for VS find-all-refs (#12107)
TIHan Sep 6, 2021
62683f1
Zero init values on demand despite SkipLocalsInit being set (#11688)
kerams Sep 6, 2021
7fa9ebf
[main] Update dependencies from dotnet/arcade (#12120)
dotnet-maestro[bot] Sep 7, 2021
212c726
Localized file check-in by OneLocBuild Task: Build definition ID 499:…
dotnet-bot Sep 7, 2021
cea8e70
Add language tags to the existing example code sections (#12129)
baronfel Sep 8, 2021
2cd818a
Sorted the string.fsi entries and added examples to each one (#12130)
MecuStefan Sep 9, 2021
4ee2816
[main] Update dependencies from dotnet/arcade (#12132)
dotnet-maestro[bot] Sep 10, 2021
e3eab10
[main] Update dependencies from dotnet/arcade (#12143)
dotnet-maestro[bot] Sep 14, 2021
108da53
Some examples for the List module. Small refactor of the String examp…
MecuStefan Sep 14, 2021
37b0a4d
Samples for seq module (#12133)
JYCabello Sep 15, 2021
63bef2c
use shipped FSHarp.Core for FSHarp.Compiler.Service.sln (#12149)
dsyme Sep 15, 2021
006bffd
add example placeholders and clean up some signature files (#12161)
dsyme Sep 16, 2021
792a5d4
code cleanup (#12121)
dsyme Sep 16, 2021
26089ea
wip
DedSec256 Aug 24, 2021
b78ba42
surface area
DedSec256 Aug 24, 2021
5a9dcee
fixes
DedSec256 Aug 25, 2021
9155794
remove unnecessary
DedSec256 Aug 25, 2021
c1afbfe
fix for test
DedSec256 Aug 25, 2021
6eaf9f4
add documentation
DedSec256 Sep 16, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[main] Update dependencies from dotnet/arcade (dotnet#11693)
* Update dependencies from https://github.com/dotnet/arcade build 20210611.3

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21311.3

* Update dependencies from https://github.com/dotnet/arcade build 20210614.1

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21311.3 -> To Version 6.0.0-beta.21314.1

* Update dependencies from https://github.com/dotnet/arcade build 20210616.3

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21316.3

* Update dependencies from https://github.com/dotnet/arcade build 20210617.1

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21316.3 -> To Version 6.0.0-beta.21317.1

* Update dependencies from https://github.com/dotnet/arcade build 20210618.2

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21318.2

* Update dependencies from https://github.com/dotnet/arcade build 20210619.2

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21319.2

* retain stable sdk

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Brett V. Forsgren <brettfo@microsoft.com>
  • Loading branch information
3 people authored Jun 21, 2021
commit 90aba6ebb375249dbd24db5e5e7b80fdd9a52a1a
4 changes: 2 additions & 2 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
@@ -8,9 +8,9 @@
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="6.0.0-beta.21303.2">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="6.0.0-beta.21319.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>78da7776965b428ff31da8f1ff2cb073506212b7</Sha>
<Sha>a3377cccde8639089f99107e2ba5df2c8cbe6394</Sha>
<SourceBuild RepoName="arcade" ManagedOnly="true" />
</Dependency>
</ToolsetDependencies>
2 changes: 1 addition & 1 deletion eng/common/dotnet-install.sh
Original file line number Diff line number Diff line change
@@ -70,7 +70,7 @@ case $cpuname in
;;
esac

dotnetRoot="$repo_root/.dotnet"
dotnetRoot="${repo_root}.dotnet"
if [[ $architecture != "" ]] && [[ $architecture != $buildarch ]]; then
dotnetRoot="$dotnetRoot/$architecture"
fi
13 changes: 10 additions & 3 deletions eng/common/generate-locproject.ps1
Original file line number Diff line number Diff line change
@@ -25,8 +25,15 @@ Push-Location "$SourcesDirectory" # push location for Resolve-Path -Relative to

# Template files
$jsonFiles = @()
$jsonFiles += Get-ChildItem -Recurse -Path "$SourcesDirectory" | Where-Object { $_.FullName -Match "\.template\.config\\localize\\en\..+\.json" } # .NET templating pattern
$jsonFiles += Get-ChildItem -Recurse -Path "$SourcesDirectory" | Where-Object { $_.FullName -Match "en\\strings\.json" } # current winforms pattern
$jsonTemplateFiles = Get-ChildItem -Recurse -Path "$SourcesDirectory" | Where-Object { $_.FullName -Match "\.template\.config\\localize\\.+\.en\.json" } # .NET templating pattern
$jsonTemplateFiles | ForEach-Object {
$null = $_.Name -Match "(.+)\.[\w-]+\.json" # matches '[filename].[langcode].json

$destinationFile = "$($_.Directory.FullName)\$($Matches.1).json"
$jsonFiles += Copy-Item "$($_.FullName)" -Destination $destinationFile -PassThru
}

$jsonWinformsTemplateFiles = Get-ChildItem -Recurse -Path "$SourcesDirectory" | Where-Object { $_.FullName -Match "en\\strings\.json" } # current winforms pattern

$xlfFiles = @()

@@ -44,7 +51,7 @@ $langXlfFiles | ForEach-Object {
$xlfFiles += Copy-Item "$($_.FullName)" -Destination $destinationFile -PassThru
}

$locFiles = $jsonFiles + $xlfFiles
$locFiles = $jsonFiles + $jsonWinformsTemplateFiles + $xlfFiles

$locJson = @{
Projects = @(
6 changes: 3 additions & 3 deletions eng/common/internal-feed-operations.ps1
Original file line number Diff line number Diff line change
@@ -45,11 +45,11 @@ function SetupCredProvider {
# Then, we set the 'VSS_NUGET_EXTERNAL_FEED_ENDPOINTS' environment variable to restore from the stable
# feeds successfully

$nugetConfigPath = "$RepoRoot\NuGet.config"
$nugetConfigPath = Join-Path $RepoRoot "NuGet.config"

if (-Not (Test-Path -Path $nugetConfigPath)) {
Write-PipelineTelemetryError -Category 'Build' -Message 'NuGet.config file not found in repo root!'
ExitWithExitCode 1
ExitWithExitCode 1
}

$endpoints = New-Object System.Collections.ArrayList
@@ -85,7 +85,7 @@ function SetupCredProvider {

#Workaround for https://github.com/microsoft/msbuild/issues/4430
function InstallDotNetSdkAndRestoreArcade {
$dotnetTempDir = "$RepoRoot\dotnet"
$dotnetTempDir = Join-Path $RepoRoot "dotnet"
$dotnetSdkVersion="2.1.507" # After experimentation we know this version works when restoring the SDK (compared to 3.0.*)
$dotnet = "$dotnetTempDir\dotnet.exe"
$restoreProjPath = "$PSScriptRoot\restore.proj"
2 changes: 1 addition & 1 deletion eng/common/internal-feed-operations.sh
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ function SetupCredProvider {
# Then, we set the 'VSS_NUGET_EXTERNAL_FEED_ENDPOINTS' environment variable to restore from the stable
# feeds successfully

local nugetConfigPath="$repo_root/NuGet.config"
local nugetConfigPath="{$repo_root}NuGet.config"

if [ ! "$nugetConfigPath" ]; then
Write-PipelineTelemetryError -category 'Build' "NuGet.config file not found in repo's root!"
4 changes: 2 additions & 2 deletions eng/common/sdk-task.ps1
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ function Print-Usage() {
function Build([string]$target) {
$logSuffix = if ($target -eq 'Execute') { '' } else { ".$target" }
$log = Join-Path $LogDir "$task$logSuffix.binlog"
$outputPath = Join-Path $ToolsetDir "$task\\"
$outputPath = Join-Path $ToolsetDir "$task\"

MSBuild $taskProject `
/bl:$log `
@@ -64,7 +64,7 @@ try {
$GlobalJson.tools | Add-Member -Name "vs" -Value (ConvertFrom-Json "{ `"version`": `"16.5`" }") -MemberType NoteProperty
}
if( -not ($GlobalJson.tools.PSObject.Properties.Name -match "xcopy-msbuild" )) {
$GlobalJson.tools | Add-Member -Name "xcopy-msbuild" -Value "16.8.0-preview3" -MemberType NoteProperty
$GlobalJson.tools | Add-Member -Name "xcopy-msbuild" -Value "16.10.0-preview2" -MemberType NoteProperty
}
if ($GlobalJson.tools."xcopy-msbuild".Trim() -ine "none") {
$xcopyMSBuildToolsFolder = InitializeXCopyMSBuild $GlobalJson.tools."xcopy-msbuild" -install $true
2 changes: 1 addition & 1 deletion eng/common/sdl/execute-all-sdl-tools.ps1
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ try {
$ErrorActionPreference = 'Stop'
Set-StrictMode -Version 2.0
$disableConfigureToolsetImport = $true
$LASTEXITCODE = 0
$global:LASTEXITCODE = 0

# `tools.ps1` checks $ci to perform some actions. Since the SDL
# scripts don't necessarily execute in the same agent that run the
2 changes: 1 addition & 1 deletion eng/common/sdl/init-sdl.ps1
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ Param(
$ErrorActionPreference = 'Stop'
Set-StrictMode -Version 2.0
$disableConfigureToolsetImport = $true
$LASTEXITCODE = 0
$global:LASTEXITCODE = 0

# `tools.ps1` checks $ci to perform some actions. Since the SDL
# scripts don't necessarily execute in the same agent that run the
2 changes: 1 addition & 1 deletion eng/common/sdl/run-sdl.ps1
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ Param(
$ErrorActionPreference = 'Stop'
Set-StrictMode -Version 2.0
$disableConfigureToolsetImport = $true
$LASTEXITCODE = 0
$global:LASTEXITCODE = 0

try {
# `tools.ps1` checks $ci to perform some actions. Since the SDL
8 changes: 8 additions & 0 deletions eng/common/templates/job/onelocbuild.yml
Original file line number Diff line number Diff line change
@@ -18,6 +18,9 @@ parameters:
LclSource: lclFilesInRepo
LclPackageId: ''
RepoType: gitHub
GitHubOrg: dotnet
MirrorRepo: ''
MirrorBranch: main
condition: ''

jobs:
@@ -66,6 +69,11 @@ jobs:
${{ if eq(parameters.RepoType, 'gitHub') }}:
repoType: ${{ parameters.RepoType }}
gitHubPatVariable: "${{ parameters.GithubPat }}"
${{ if ne(parameters.MirrorRepo, '') }}:
isMirrorRepoSelected: true
gitHubOrganization: ${{ parameters.GitHubOrg }}
mirrorRepo: ${{ parameters.MirrorRepo }}
mirrorBranch: ${{ parameters.MirrorBranch }}
condition: ${{ parameters.condition }}

- task: PublishBuildArtifacts@1
6 changes: 5 additions & 1 deletion eng/common/templates/job/source-index-stage1.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
parameters:
runAsPublic: false
sourceIndexPackageVersion: 1.0.1-20210421.1
sourceIndexPackageVersion: 1.0.1-20210614.1
sourceIndexPackageSource: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json
sourceIndexBuildCommand: powershell -NoLogo -NoProfile -ExecutionPolicy Bypass -Command "eng/common/build.ps1 -restore -build -binarylog -ci"
preSteps: []
binlogPath: artifacts/log/Debug/Build.binlog
pool:
vmImage: vs2017-win2016
condition: ''
dependsOn: ''

jobs:
- job: SourceIndexStage1
dependsOn: ${{ parameters.dependsOn }}
condition: ${{ parameters.condition }}
variables:
- name: SourceIndexPackageVersion
value: ${{ parameters.sourceIndexPackageVersion }}
99 changes: 46 additions & 53 deletions eng/common/tools.ps1
Original file line number Diff line number Diff line change
@@ -193,38 +193,42 @@ function InitializeDotNetCli([bool]$install, [bool]$createSdkLocationFile) {
return $global:_DotNetInstallDir = $dotnetRoot
}

function Retry($downloadBlock, $maxRetries = 5) {
$retries = 1

while($true) {
try {
& $downloadBlock
break
}
catch {
Write-PipelineTelemetryError -Category 'InitializeToolset' -Message $_
}

if (++$retries -le $maxRetries) {
$delayInSeconds = [math]::Pow(2, $retries) - 1 # Exponential backoff
Write-Host "Retrying. Waiting for $delayInSeconds seconds before next attempt ($retries of $maxRetries)."
Start-Sleep -Seconds $delayInSeconds
}
else {
Write-PipelineTelemetryError -Category 'InitializeToolset' -Message "Unable to download file in $maxRetries attempts."
break
}

}
}

function GetDotNetInstallScript([string] $dotnetRoot) {
$installScript = Join-Path $dotnetRoot 'dotnet-install.ps1'
if (!(Test-Path $installScript)) {
Create-Directory $dotnetRoot
$ProgressPreference = 'SilentlyContinue' # Don't display the console progress UI - it's a huge perf hit

$maxRetries = 5
$retries = 1

$uri = "https://dot.net/$dotnetInstallScriptVersion/dotnet-install.ps1"

while($true) {
try {
Write-Host "GET $uri"
Invoke-WebRequest $uri -OutFile $installScript
break
}
catch {
Write-Host "Failed to download '$uri'"
Write-Error $_.Exception.Message -ErrorAction Continue
}

if (++$retries -le $maxRetries) {
$delayInSeconds = [math]::Pow(2, $retries) - 1 # Exponential backoff
Write-Host "Retrying. Waiting for $delayInSeconds seconds before next attempt ($retries of $maxRetries)."
Start-Sleep -Seconds $delayInSeconds
}
else {
throw "Unable to download file in $maxRetries attempts."
}

}
Retry({
Write-Host "GET $uri"
Invoke-WebRequest $uri -OutFile $installScript
})
}

return $installScript
@@ -308,8 +312,8 @@ function InitializeVisualStudioMSBuild([bool]$install, [object]$vsRequirements =

# If the version of msbuild is going to be xcopied,
# use this version. Version matches a package here:
# https://dev.azure.com/dnceng/public/_packaging?_a=package&feed=dotnet-eng&package=RoslynTools.MSBuild&protocolType=NuGet&version=16.8.0-preview3&view=overview
$defaultXCopyMSBuildVersion = '16.8.0-preview3'
# https://dev.azure.com/dnceng/public/_packaging?_a=package&feed=dotnet-eng&package=RoslynTools.MSBuild&protocolType=NuGet&version=16.10.0-preview2&view=overview
$defaultXCopyMSBuildVersion = '16.10.0-preview2'

if (!$vsRequirements) { $vsRequirements = $GlobalJson.tools.vs }
$vsMinVersionStr = if ($vsRequirements.version) { $vsRequirements.version } else { $vsMinVersionReqdStr }
@@ -403,9 +407,13 @@ function InitializeXCopyMSBuild([string]$packageVersion, [bool]$install) {
}

Create-Directory $packageDir

Write-Host "Downloading $packageName $packageVersion"
$ProgressPreference = 'SilentlyContinue' # Don't display the console progress UI - it's a huge perf hit
Invoke-WebRequest "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/flat2/$packageName/$packageVersion/$packageName.$packageVersion.nupkg" -OutFile $packagePath
Retry({
Invoke-WebRequest "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/flat2/$packageName/$packageVersion/$packageName.$packageVersion.nupkg" -OutFile $packagePath
})

Unzip $packagePath $packageDir
}

@@ -442,27 +450,9 @@ function LocateVisualStudio([object]$vsRequirements = $null){
if (!(Test-Path $vsWhereExe)) {
Create-Directory $vsWhereDir
Write-Host 'Downloading vswhere'
$maxRetries = 5
$retries = 1

while($true) {
try {
Invoke-WebRequest "https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/vswhere/$vswhereVersion/vswhere.exe" -OutFile $vswhereExe
break
}
catch{
Write-PipelineTelemetryError -Category 'InitializeToolset' -Message $_
}

if (++$retries -le $maxRetries) {
$delayInSeconds = [math]::Pow(2, $retries) - 1 # Exponential backoff
Write-Host "Retrying. Waiting for $delayInSeconds seconds before next attempt ($retries of $maxRetries)."
Start-Sleep -Seconds $delayInSeconds
}
else {
Write-PipelineTelemetryError -Category 'InitializeToolset' -Message "Unable to download file in $maxRetries attempts."
}
}
Retry({
Invoke-WebRequest "https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/vswhere/$vswhereVersion/vswhere.exe" -OutFile $vswhereExe
})
}

if (!$vsRequirements) { $vsRequirements = $GlobalJson.tools.vs }
@@ -498,7 +488,7 @@ function InitializeBuildTool() {
if (Test-Path variable:global:_BuildTool) {
# If the requested msbuild parameters do not match, clear the cached variables.
if($global:_BuildTool.Contains('ExcludePrereleaseVS') -and $global:_BuildTool.ExcludePrereleaseVS -ne $excludePrereleaseVS) {
Remove-Item variable:global:_BuildTool
Remove-Item variable:global:_BuildTool
Remove-Item variable:global:_MSBuildExe
} else {
return $global:_BuildTool
@@ -555,7 +545,7 @@ function GetDefaultMSBuildEngine() {

function GetNuGetPackageCachePath() {
if ($env:NUGET_PACKAGES -eq $null) {
# Use local cache on CI to ensure deterministic build.
# Use local cache on CI to ensure deterministic build.
# Avoid using the http cache as workaround for https://github.com/NuGet/Home/issues/3116
# use global cache in dev builds to avoid cost of downloading packages.
# For directory normalization, see also: https://github.com/NuGet/Home/issues/7968
@@ -712,7 +702,10 @@ function MSBuild-Core() {
}

foreach ($arg in $args) {
if ($arg -ne $null -and $arg.Trim() -ne "") {
if ($null -ne $arg -and $arg.Trim() -ne "") {
if ($arg.EndsWith('\')) {
$arg = $arg + "\"
}
$cmdArgs += " `"$arg`""
}
}
@@ -784,7 +777,7 @@ function Get-Darc($version) {

. $PSScriptRoot\pipeline-logging-functions.ps1

$RepoRoot = Resolve-Path (Join-Path $PSScriptRoot '..\..')
$RepoRoot = Resolve-Path (Join-Path $PSScriptRoot '..\..\')
$EngRoot = Resolve-Path (Join-Path $PSScriptRoot '..')
$ArtifactsDir = Join-Path $RepoRoot 'artifacts'
$ToolsetDir = Join-Path $ArtifactsDir 'toolset'
9 changes: 5 additions & 4 deletions eng/common/tools.sh
Original file line number Diff line number Diff line change
@@ -485,13 +485,14 @@ _script_dir=`dirname "$_ResolvePath"`

eng_root=`cd -P "$_script_dir/.." && pwd`
repo_root=`cd -P "$_script_dir/../.." && pwd`
artifacts_dir="$repo_root/artifacts"
repo_root="${repo_root}/"
artifacts_dir="${repo_root}artifacts"
toolset_dir="$artifacts_dir/toolset"
tools_dir="$repo_root/.tools"
tools_dir="${repo_root}.tools"
log_dir="$artifacts_dir/log/$configuration"
temp_dir="$artifacts_dir/tmp/$configuration"

global_json_file="$repo_root/global.json"
global_json_file="${repo_root}global.json"
# determine if global.json contains a "runtimes" entry
global_json_has_runtimes=false
if command -v jq &> /dev/null; then
@@ -504,7 +505,7 @@ fi

# HOME may not be defined in some scenarios, but it is required by NuGet
if [[ -z $HOME ]]; then
export HOME="$repo_root/artifacts/.home/"
export HOME="${repo_root}artifacts/.home/"
mkdir -p "$HOME"
fi

2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@
}
},
"msbuild-sdks": {
"Microsoft.DotNet.Arcade.Sdk": "6.0.0-beta.21303.2",
"Microsoft.DotNet.Arcade.Sdk": "6.0.0-beta.21319.2",
"Microsoft.DotNet.Helix.Sdk": "2.0.0-beta.19069.2"
}
}