Extension Typing Shim

.devcontainer/Dockerfile

@@ -0,0 +1,40 @@
+#-------------------------------------------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information.
+#-------------------------------------------------------------------------------------------------------------
+
+FROM mcr.microsoft.com/dotnet/core/sdk:3.1
+
+# Avoid warnings by switching to noninteractive
+ENV DEBIAN_FRONTEND=noninteractive
+
+# This Dockerfile adds a non-root user with sudo access. Use the "remoteUser"
+# property in devcontainer.json to use it. On Linux, the container user's GID/UIDs
+# will be updated to match your local UID/GID (when using the dockerFile property).
+# See https://aka.ms/vscode-remote/containers/non-root-user for details.
+ARG USERNAME=vscode
+ARG USER_UID=1000
+ARG USER_GID=$USER_UID
+
+# Configure apt and install packages
+RUN apt-get update \
+    && apt-get -y install --no-install-recommends apt-utils dialog 2>&1 \
+    #
+    # Verify git, process tools, lsb-release (common in install instructions for CLIs) installed
+    && apt-get -y install git openssh-client less iproute2 procps lsb-release \
+    #
+    # Create a non-root user to use if preferred - see https://aka.ms/vscode-remote/containers/non-root-user.
+    && groupadd --gid $USER_GID $USERNAME \
+    && useradd -s /bin/bash --uid $USER_UID --gid $USER_GID -m $USERNAME \
+    # [Optional] Add sudo support for the non-root user
+    && apt-get install -y sudo \
+    && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME\
+    && chmod 0440 /etc/sudoers.d/$USERNAME \
+    #
+    # Clean up
+    && apt-get autoremove -y \
+    && apt-get clean -y \
+    && rm -rf /var/lib/apt/lists/*
+
+# Switch back to dialog for any ad-hoc use of apt-get
+ENV DEBIAN_FRONTEND=dialog

.devcontainer/devcontainer.json

@@ -0,0 +1,34 @@
+// For format details, see https://aka.ms/vscode-remote/devcontainer.json or this file's README at:
+// https://github.com/microsoft/vscode-dev-containers/tree/v0.108.0/containers/dotnetcore-3.1-fsharp
+{
+	"name": "F# (.NET Core 3.1)",
+	"dockerFile": "Dockerfile",
+
+	// Set *default* container specific settings.json values on container create.
+	//
+	// .NET Core is now the default for F# in .NET Core 3.0+
+	// However, .NET Core scripting is not the default yet. Set that to true.
+	"settings": {
+		"terminal.integrated.shell.linux": "/bin/bash",
+		"FSharp.useSdkScripts":true,
+		"editor.trimAutoWhitespace": false,
+		"files.trimTrailingWhitespace": false,
+		"FSharp.suggestGitignore": false,
+		"FSharp.workspacePath": "FSharp.sln"
+	},
+
+	// Add the IDs of extensions you want installed when the container is created.
+	"extensions": [
+		"Ionide.Ionide-fsharp",
+		"ms-dotnettools.csharp"
+	],
+
+	// Use 'forwardPorts' to make a list of ports inside the container available locally.
+	// "forwardPorts": [],
+
+	// Use 'postCreateCommand' to run commands after the container is created.
+	"postCreateCommand": "./build.sh",
+
+	// Uncomment to connect as a non-root user. See https://aka.ms/vscode-remote/containers/non-root.
+	// "remoteUser": "vscode"
+}

.github/ISSUE_TEMPLATE/feature_request.md

@@ -8,13 +8,21 @@ assignees: ''
 ---
 
 **Is your feature request related to a problem? Please describe.**
+
 A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
 
 **Describe the solution you'd like**
+
 A clear and concise description of what you want to happen.
 
 **Describe alternatives you've considered**
+
 A clear and concise description of any alternative solutions or features you've considered.
 
 **Additional context**
+
+If the issue is about:
+* improving a compiler error message, please mention "related: #1103"
+* improving/adjusting the parser, please mention "related: #11481"
+
 Add any other context or screenshots about the feature request here.

.gitignore

@@ -1,5 +1,6 @@
 # output location
 artifacts/
+BenchmarkDotNet.Artifacts/
 
 /tests/scripts/current
 .dotnet/
@@ -9,50 +10,29 @@ artifacts/
 # Patches that may have been generated by scripts.
 # (These aren't generally useful to commit directly; if anything, they should be applied.)
 scripts/*.patch
-/fcs/FSharp.Compiler.Service/illex.fs
-/fcs/FSharp.Compiler.Service/ilpars.fs
-/fcs/FSharp.Compiler.Service/ilpars.fsi
-/fcs/FSharp.Compiler.Service/lex.fs
-/fcs/FSharp.Compiler.Service/pars.fs
-/fcs/FSharp.Compiler.Service/pars.fsi
-/fcs/FSharp.Compiler.Service/pplex.fs
-/fcs/FSharp.Compiler.Service/pppars.fs
-/fcs/FSharp.Compiler.Service/pppars.fsi
 /src/*.userprefs
 /src/fsharp/FSStrings.resources
 /src/fsharp/FSharp.Build/*.resx
-/src/fsharp/FSharp.Build-proto/*.resx
-/src/fsharp/FSharp.Build-proto/*.resources
-/src/fsharp/FSharp.Compiler-proto/*.resx
-/src/fsharp/FSharp.Compiler-proto/*.resources
-/src/fsharp/FSharp.Compiler-proto/*.sln
-/src/fsharp/FSharp.Compiler-proto/*.userprefs
 /src/fsharp/fsi/*.resx
 /src/fsharp/FSharp.Compiler.Interactive.Settings/*.resx
 /src/fsharp/FSharp.Compiler.Server.Shared/*.resx
 /src/fsharp/fsi/Fsi.sln
 /src/fsharp/FSharp.Build/*.resources
-/src/fsharp/FSharp.Compiler.Private/*.resx
-/src/fsharp/FSharp.Compiler.Private/*.resources
-/src/fsharp/FSharp.Compiler.Private/*.sln
-/src/fsharp/FSharp.Compiler.Private/*.userprefs
+/src/fsharp/FSharp.Compiler.Service/*.resx
+/src/fsharp/FSharp.Compiler.Service/*.resources
+/src/fsharp/FSharp.Compiler.Service/*.sln
+/src/fsharp/FSharp.Compiler.Service/*.userprefs
+/src/fsharp/FSharp.Compiler.Service/StandardOutput.txt
+/src/fsharp/FSharp.Compiler.Service/StandardError.txt
 /src/*.log
-/src/fsharp/Fsc-proto/illex.fs
-/src/fsharp/Fsc-proto/ilpars.fs
-/src/fsharp/Fsc-proto/ilpars.fsi
-/src/fsharp/Fsc-proto/lex.fs
-/src/fsharp/Fsc-proto/pars.fs
-/src/fsharp/Fsc-proto/pars.fsi
-/src/fsharp/Fsc-proto/pplex.fs
-/src/fsharp/Fsc-proto/pppars.fs
-/src/fsharp/Fsc-proto/pppars.fsi
 /src/fsharp/FSharp.LanguageService.Compiler/illex.*
 /src/fsharp/FSharp.LanguageService.Compiler/ilpars.*
 /src/fsharp/FSharp.LanguageService.Compiler/lex.*
 /src/fsharp/FSharp.LanguageService.Compiler/pars.*
 /src/fsharp/FSharp.LanguageService.Compiler/pplex.fs
 /src/fsharp/FSharp.LanguageService.Compiler/pppars.fs
 /src/fsharp/FSharp.LanguageService.Compiler/pppars.fsi
+/src/fsharp/*/Properties/launchSettings.json
 /vsintegration/src/unittests/Unittests.fsi
 /tests/*FSharp_Failures.env
 /tests/*FSharp_Failures.lst
@@ -130,3 +110,17 @@ msbuild.binlog
 /fcs/FSharp.Compiler.Service.netstandard/*.fsi
 /.ionide/
 **/.DS_Store
+/tests/fsharp/regression/5531/compilation.output.test.txt
+/tests/fsharp/core/fsfromfsviacs/compilation.langversion.old.output.txt
+/tests/fsharp/core/fsfromfsviacs/compilation.errors.output.txt
+*ncrunch*.user
+_NCrunch_*
+.*crunch*.local.xml
+nCrunchTemp_*
+
+.idea
+/tests/fsharp/core/members/set-only-property/vb.dll
+/tests/fsharp/core/members/set-only-property/fs.dll
+/tests/fsharp/core/members/set-only-property/cs.dll
+
+.fake

.vscode/settings.json

@@ -0,0 +1,7 @@
+{
+    "editor.trimAutoWhitespace": false,
+    "files.trimTrailingWhitespace": false,
+    "FSharp.suggestGitignore": false,
+    "FSharp.workspacePath": "FSharp.sln",
+    "dotnet-test-explorer.testProjectPath": "tests/*Tests/"
+}

.vsconfig

@@ -8,8 +8,6 @@
     "Microsoft.VisualStudio.Component.Roslyn.Compiler",
     "Microsoft.VisualStudio.Component.Roslyn.LanguageServices",
     "Microsoft.VisualStudio.Component.FSharp",
-    "Microsoft.Net.Core.Component.SDK.2.1",
-    "Microsoft.NetCore.ComponentGroup.DevelopmentTools.2.1",
     "Microsoft.Net.Component.4.7.2.SDK",
     "Microsoft.Net.Component.4.7.2.TargetingPack",
     "Microsoft.Net.ComponentGroup.DevelopmentPrerequisites",