Fix X2 Omni

[edenhaus]

See home-assistant/core#110177

Summary by CodeRabbit

• New Features

  • Enhanced cleaning functionality allows for simultaneous processing of STOP and PAUSE actions, improving user control.
  • Updated cleaning command classes to newer versions for better performance and additional features.

• Bug Fixes

  • Improved state management for cleaning commands, leading to more accurate reporting and handling of cleaning status.

[coderabbitai]

Walkthrough

The recent changes update the deebot_client by modifying the _get_args function to handle both CleanAction.STOP and CleanAction.PAUSE together. Additionally, the cleaning command classes have been renamed to their newer versions, CleanV2 and GetCleanInfoV2, reflecting enhancements in functionality. These updates streamline the logic for cleaning actions and improve the overall command handling in the system.

Changes

Files	Change Summary
deebot_client/commands/json/clean.py	Modified _get_args to handle CleanAction.STOP and CleanAction.PAUSE together; renamed Clean to CleanV2, GetCleanInfo to GetCleanInfoV2.
deebot_client/hardware/deebot/e6ofmn.py	Updated to use CleanV2 and GetCleanInfoV2 in place of the older classes for improved functionality and state management.

Poem

🐰 Hopping through code, oh what a delight,
Clean commands sparkle, shining so bright!
With new actions dancing, a pause or a stop,
Our cleaning adventures will never drop!
Here's to enhancements, let’s cheer and rejoice,
Code bunnies together, we hop with one voice! 🎉✨

Tip

We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c258d0d and e5025fb.

Files selected for processing (2)

• deebot_client/commands/json/clean.py (1 hunks)
• deebot_client/hardware/deebot/e6ofmn.py (3 hunks)

Additional comments not posted (4)

deebot_client/commands/json/clean.py (1)

85-85: LGTM! The change improves the function's capability.

The use of a bitwise OR operator to handle both STOP and PAUSE actions is logical and enhances the function's capability.

deebot_client/hardware/deebot/e6ofmn.py (3)

29-29: LGTM! The import changes are appropriate.

Replacing the older cleaning command classes with their newer versions suggests an enhancement in functionality.

---

115-115: LGTM! The update to CapabilityClean is appropriate.

The shift to CleanV2 indicates an improvement in the underlying implementation of the cleaning command.

---

211-211: LGTM! The update to CapabilityEvent is appropriate.

Including GetCleanInfoV2 likely provides more detailed or structured data about the cleaning state.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.67%. Comparing base (fafef75) to head (5bf8980).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #552   +/-   ##
=======================================
  Coverage   86.67%   86.67%           
=======================================
  Files          89       89           
  Lines        3324     3324           
  Branches      533      533           
=======================================
  Hits         2881     2881           
  Misses        389      389           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sebcbien37]

Hi, I have have home assistant on docker and I have a deeboot X2 but I don't know how I can try your code on my installation.

[edenhaus]

I would recommend spinning up a home assistant dev env, where you manually install this branch.
Using a dedicated system to test has many advantages, and the biggest one is, that you don't break our production instance if something goes wrong

[mgguinne]

It confirmed working for me in my Hass Dev instance :) Great work !!!
What's the next step to get this merged in Hass?
Anyway to merge the code into my production instance, it's clear to me it won't break it!

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e5025fb and 5bf8980.

Files selected for processing (1)

• deebot_client/commands/json/clean.py (1 hunks)

Additional comments not posted (1)

deebot_client/commands/json/clean.py (1)

88-88: LGTM!

The code changes are approved. The update to the case statement for handling both CleanAction.STOP and CleanAction.PAUSE actions together is a good enhancement that streamlines the logic.