Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide TypeScript definitions #3

Closed
LeoDanielsson opened this issue Mar 14, 2024 · 1 comment · Fixed by #6
Closed

Provide TypeScript definitions #3

LeoDanielsson opened this issue Mar 14, 2024 · 1 comment · Fixed by #6
Assignees

Comments

@LeoDanielsson
Copy link

This package lacks TypeScript definitions, which is a problem for projects with typed build configuration, such as Vite.

@IanVS IanVS self-assigned this Mar 14, 2024
@IanVS IanVS closed this as completed in #6 Mar 19, 2024
IanVS added a commit that referenced this issue Mar 19, 2024
Fixes #3 by converting the project over to TypeScript and publishing index.d.ts alongside the generated index.js file, which TypeScript should automatically resolve.
@IanVS
Copy link
Collaborator

IanVS commented Mar 19, 2024

Thanks @LeoDanielsson. I've cleaned up the package a bit, converted it to TypeScript, and now dual-publish ESM and CJS along with types for each. Try out the latest 0.3.0 version and let me know if you hit any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants