Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert project to TypeScript #6

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Convert project to TypeScript #6

merged 3 commits into from
Mar 19, 2024

Conversation

IanVS
Copy link
Collaborator

@IanVS IanVS commented Mar 19, 2024

Fixes #3 by converting the project over to TypeScript and publishing index.d.ts alongside the generated index.js file, which TypeScript should automatically resolve.

@IanVS IanVS requested a review from jasikpark March 19, 2024 15:31
jasikpark
jasikpark approved these changes Mar 19, 2024
View reviewed changes
Copy link

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me, we can test w/ arethetypeswrong after

(actually i think there's a cli for it now?)

@IanVS IanVS merged commit d9ac817 into main Mar 19, 2024
6 checks passed
@IanVS IanVS deleted the typescript branch March 19, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasikpark jasikpark jasikpark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide TypeScript definitions
2 participants
@IanVS @jasikpark