Change Kill Person to "Teach person a lesson" #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
Changes: YML
Lyndomen
changed the title
|
peak |
|
I love it, gives way more room for RP |
|
inb4 an ESL player attempts to teach their kill target arithmetic |
Colin-Tel
previously approved these changes
Nov 13, 2024
|
Still needs a code review 😄 |
|
good code, peak code even |
deltanedas
requested changes
Nov 13, 2024
|
i have made it its own codition, but not ready for review- it is still actively broken. I intend to make it so calling cards can be slapped against a body, and that will hopefully satisfy the condition. |
deltanedas
requested changes
Nov 14, 2024
Content.Server/DeltaV/Objectives/Components/TeachLessonConditionComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/Objectives/Components/TeachLessonConditionComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/Objectives/Components/TeachLessonPickRandomHeadComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/Objectives/Components/TeachLessonPickRandomPersonComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/Objectives/Systems/TeachLessonConditionSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/Objectives/Systems/TeachLessonConditionSystem.cs
Outdated
Show resolved
Hide resolved
Resources/Locale/en-US/deltav/objectives/conditions/teach-head.ftl
Outdated
Show resolved
Hide resolved
|
ok real i understand how to use randomperson, just trust the process. this still has the limitation that beck has indicated, in that people have to check their objectives while the fella is dead, but i can start working on that next |
deltanedas
requested changes
Nov 15, 2024
Content.Server/DeltaV/Objectives/Systems/TeachLessonConditionSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/Objectives/Components/TeachLessonConditionComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/Objectives/Systems/TeachLessonConditionSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/Objectives/Systems/TeachLessonConditionSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/Objectives/Systems/TeachLessonConditionSystem.cs
Outdated
Show resolved
Hide resolved
|
|
deltanedas
requested changes
Nov 15, 2024
Content.Server/DeltaV/Objectives/Systems/TeachLessonConditionSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/Objectives/Systems/TeachLessonConditionSystem.cs
Outdated
Show resolved
Hide resolved
MilonPL
suggested changes
Nov 15, 2024
Content.Server/DeltaV/Objectives/Systems/TeachLessonConditionSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/Objectives/Systems/TeachLessonConditionSystem.cs
Outdated
Show resolved
Hide resolved
MilonPL
approved these changes
Nov 15, 2024
deltanedas
approved these changes
Nov 18, 2024
DisposableCrewmember42
pushed a commit
to DisposableCrewmember42/Delta-v
that referenced
this pull request
Nov 18, 2024
* bogos binted * bogos binted * bogos binted * bogos binted * bogos binted * bogos binted * bogos binted * fixes, still doesnt stay completed. * fixed real * meow * meow
|
Changelog didn't work, damn |
2 tasks
|
shit |
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Normal targets only have to die once, from then on the greentext is green. kill head turns red if they get revived though.
Why / Balance
Its cooler for everyone involved, and hopefully encourages more interesting murders. Heads still get to be gibbed because they signed up for it :godo:
Technical details
C# changes imported from April (thank you) and some EE dependencies. Moved their stuff to a EE folder.
This is my first time porting something so please triple check.
Media
wow look we have to teach them a lesson
wow look we killed them and its green
wow look they are revived, and its still green
uh oh wow look we have to kill CE
Got em
i forgot to save the last screenshot but it reverts to redtext if CE gets revived
Requirements
Breaking changes
damn idk
Changelog
🆑 Lyndomen, Sleepy.April