Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Changelog Entry for Teach Lesson #2225

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

Lyndomen
Copy link
Contributor

@Lyndomen Lyndomen commented Nov 18, 2024

About the PR

Changelog missing from #2184

Why / Balance

It is important to let people know

Technical details

yaml, but idk if its better of CL it here too

Media

no

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog
🆑 Lyndomen, SleepyApril

  • tweak: Normal kill targets now just need to be killed once- but it needs to teach them a lesson that will be remembered

@Lyndomen Lyndomen requested a review from a team as a code owner November 18, 2024 15:12
@github-actions github-actions bot added the Changes: YML Changes any yml files label Nov 18, 2024
Copy link
Member

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add it to this pr's cl and wait for publish

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen Lyndomen requested a review from MilonPL November 18, 2024 15:30
@Lyndomen
Copy link
Contributor Author

if someone can check the CL, i think its the double person that fucked it up fucked if i know

@Lyndomen Lyndomen requested a review from deltanedas November 18, 2024 15:31
@MilonPL
Copy link
Member

MilonPL commented Nov 18, 2024

yes real it was the dot in the name

@Lyndomen
Copy link
Contributor Author

yes real it was the dot in the name

:trollface:

@deltanedas deltanedas merged commit 01b9d6e into DeltaV-Station:master Nov 19, 2024
12 checks passed
DisposableCrewmember42 pushed a commit to DisposableCrewmember42/Delta-v that referenced this pull request Nov 19, 2024
* meow

* meow

* Update DeltaVChangelog.yml

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>

---------

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
DisposableCrewmember42 pushed a commit to DisposableCrewmember42/Delta-v that referenced this pull request Nov 19, 2024
* meow

* meow

* Update DeltaVChangelog.yml

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>

---------

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@jimmy12or
Copy link
Contributor

But... you're not allowed to remember.

@Lyndomen
Copy link
Contributor Author

But... you're not allowed to remember.

People can tell you "bruh you just got eaten by carp, who did you piss off"

@Radezolid
Copy link
Contributor

But... you're not allowed to remember.

You are not allowed to remember your killer, you can recall being beaten up with a bat "for some weird shit they were yelling that it was my fault" or something alike.

@Lyndomen Lyndomen deleted the noclnofun branch November 20, 2024 20:35
MilonPL added a commit that referenced this pull request Nov 29, 2024
* feat: Powdered drinks orderable by Logi

* tweak: Lower amounts per crate

* chore: fix copy-paste mistake

* feat: Add HydroCo to StockTrade App

* tweak: Lemon, Lime and Pineapple Juice powders now deal slight Caustic damage

* i18n: Powdered watermelon juice does not include water

* feat: If eating straight powdered beverage, cough and vomit

* tweak: change powder tastes

* tweak: Add spoons to HydroCo crates

* tweak: Add HydroCo consumption notice to crates

* refactor: consistent naming

* refactor: BasePowderBeverage now abstract, inherit physicalDesc

* refactor: mark ReagentTinBase as abstract

* tweak: Rephrase HydroCo Notice

* refactor: Move name and description to prototype

* tweak: Juice crate now comes in one of four editions

* feat: powdered tomato juice

* refactor: rename reagent ftl for consistendcy

* tweak: use tomato powder in crate fill

* fix: copy-paste mistake

* feat: hydroco trial mails

* tweak: 2 soy, 2 regular milk in dairy crate

* tweak: lower price for juice crate

* tweak: recolor tomato powder

* tweak: use one of each edition, no themed crates; plastic spoons instead of metal

* feat: soy milk powder and orange juice powder in sustenance vendor

* tweak: reword hydroco mail message

* tweak: rearrange papers to play nicer with word-wrap

* tweak: add new-line in case somebody drags the paper wider

* tweak: reintroduce random tin, condense juice fill tables

* refactor: amount defaults to 1

* Add Changelog Entry for Teach Lesson (#2225)

* meow

* meow

* Update DeltaVChangelog.yml

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>

---------

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>

* refactor: add missing newline

* refactor: respect yaml property ordering convention

* refactor: more yaml conventions

---------

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
Signed-off-by: DisposableCrewmember42 <disposablecrewmember42@proton.me>
Co-authored-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
Co-authored-by: Milon <milonpl.git@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants