Various Improvements to NanoChat #2922
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/L
dvir001
suggested changes
Feb 7, 2025
|
merge is from wizden, i made it, hi |
I tried to look there but the relevant commits are for NanoChat which isn't on wizden, if I'm not mistaken |
I made them in the PR, silly of me I know |
Toby222
changed the title
deltanedas
requested changes
Feb 23, 2025
Comment on lines
+43
to
+46
| common.AddFunction(ContentKeyFunctions.NanoChatNavigateUp); // DeltaV - NanoChat keybinds | ||
| common.AddFunction(ContentKeyFunctions.NanoChatNavigateDown); // DeltaV - NanoChat keybinds | ||
| common.AddFunction(ContentKeyFunctions.NanoChatNavigateUpUnread); // DeltaV - NanoChat keybinds | ||
| common.AddFunction(ContentKeyFunctions.NanoChatNavigateDownUnread); // DeltaV - NanoChat keybinds |
Comment on lines
+243
to
+247
| AddHeader("ui-options-header-nano-chat"); | ||
| AddButton(ContentKeyFunctions.NanoChatNavigateUp); // DeltaV - NanoChat keybinds | ||
| AddButton(ContentKeyFunctions.NanoChatNavigateDown); // DeltaV - NanoChat keybinds | ||
| AddButton(ContentKeyFunctions.NanoChatNavigateUpUnread); // DeltaV - NanoChat keybinds | ||
| AddButton(ContentKeyFunctions.NanoChatNavigateDownUnread); // DeltaV - NanoChat keybinds |
| @@ -229,6 +290,15 @@ private void HandleToggleMute(Entity<NanoChatCardComponent> card) | |||
| UpdateUIForCard(card); | |||
| } | |||
|
|
|||
| private void HandleToggleMuteChat(Entity<NanoChatCardComponent> card, NanoChatUiMessageEvent msg) | |||
| { | |||
| Log.Debug($"Toggling mute for chat #{msg.RecipientNumber:D4} on card #{card.Comp.Number:D4}"); | |||
There was a problem hiding this comment.
What does this mean?
Comment on lines
+604
to
+607
| private static string Truncate(string text, int maxLength, string overflowText = "...") => | ||
| text.Length <= maxLength | ||
| ? text | ||
| : text[..(maxLength - overflowText.Length)] + overflowText; |
There was a problem hiding this comment.
put this in shared so ui doesnt copy paste it
Comment on lines
+27
to
+30
| public static readonly BoundKeyFunction NanoChatNavigateUp = "NanoChatNavigateUp"; // DeltaV - Keybinds for NanoChat | ||
| public static readonly BoundKeyFunction NanoChatNavigateDown = "NanoChatNavigateDown"; // DeltaV - Keybinds for NanoChat | ||
| public static readonly BoundKeyFunction NanoChatNavigateUpUnread = "NanoChatNavigateUpUnread"; // DeltaV - Keybinds for NanoChat | ||
| public static readonly BoundKeyFunction NanoChatNavigateDownUnread = "NanoChatNavigateDownUnread"; // DeltaV - Keybinds for NanoChat |
Comment on lines
173
to
+174
| # DeltaV - Swap Hands Reversed End | ||
| # DeltaV - NanoChat keybinds Start |
There was a problem hiding this comment.
remove middle comments and change outer to Begin DeltaV Additions / End DeltaV Additions
no reason to have separate comments for 1 thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Why / Balance
NanoChat as-is is still not very nice to use. These changes should ideally make it a good alternative communication method to trying to call out people in common.
Technical details
Some ported from:
Media
2025-02-08.01-36-20.mp4
2025-02-08.01-43-33.mp4
2025-02-08.01-48-51.mp4
Requirements
Breaking changes
Changelog
🆑