forked from space-wizards/space-station-14
-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nanochat Improvements and Lookup (DV Port) #1692
Merged
formlessnameless
merged 14 commits into
impstation:master
from
honeyed-lemons:nanochat-improvements
Feb 17, 2025
Merged
Nanochat Improvements and Lookup (DV Port) #1692
formlessnameless
merged 14 commits into
impstation:master
from
honeyed-lemons:nanochat-improvements
Feb 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* NanoChat Phonebook MVP * Only work with active Telecomms server with correct channel * Add localization and program sprite * Cartridge icon * Only preinstall on HoP, Courier, and QM PDAs * untroll, fix formatting * fix double newline * replace NanoChat lookup cartridge with UI elements * List Number setting in NanoChat instead of PDA * replace NanoChat lookup cartridge with UI elements * re-fuck formatting just to make the diff on GitHub nicer * remove superfluous svg * remove leftovers I somehow created * address simple requested changes; remove more leftovers * NanoChat lookup to own Container * fix indentation (cherry picked from commit 27383be3dc9a66c409d444b59601c344b013576a)
…uttons next to the message box
kipdotnet
approved these changes
Feb 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functions perfectly as far as I can tell. no errors, and fixes a bunch of annoyances. approving but wont be merged pending proper code review
ruddygreat
reviewed
Feb 16, 2025
Content.Client/_DV/CartridgeLoader/Cartridges/NanoChatEntry.xaml.cs
Outdated
Show resolved
Hide resolved
ruddygreat
reviewed
Feb 16, 2025
Content.Client/_DV/CartridgeLoader/Cartridges/NanoChatLookupView.xaml.cs
Outdated
Show resolved
Hide resolved
ruddygreat
reviewed
Feb 16, 2025
ruddygreat
reviewed
Feb 16, 2025
Content.Server/_DV/CartridgeLoader/Cartridges/NanoChatCartridgeSystem.cs
Show resolved
Hide resolved
Toby222
suggested changes
Feb 17, 2025
Content.Client/_DV/CartridgeLoader/Cartridges/NanoChatLookupView.xaml.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports two Nanochat PRs from DeltaV
Changelog
🆑 Toby222, Honeyed_Lemons_