-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading of [sedtrails] section in .mdu #620
Comments
As we understand, the goal for this issue is:
@veenstrajelmer & @rhutten is this correct? |
I have asked @hrajagers by email what all the keywords are that are supported for the |
I got a very elaborate answer, I will post it here (in Dutch):
|
@SCLaan I assume you do not use this section yourself, but you just noticed in the diafile, correct? I have not seen this section in diafiles recently. Do you have an example where it does show up (including a dimrset version number)? It might be removed from the standard diafile? The |
Recently Julien made quite some changes to the .dia. Some input, such as the [sedtrails]-section doesn't show anymore, unless users place it in the .mdu. Juliens changes:
My reason to open this issue was that I (and others) often copy the .dia as a starting point of a new .mdu to have the latest overview of keywords. With this change this will no longer cause a problem. It will however still be a problem for users that do use sedtrails. I guess the broader point is that right now HYDROLIB-core cannot handle unknown sections. Unknown keywords are caught in the comments, but newly added sections cause a validation error.
|
Describe the bug
HYDROLIB-core 0.7.0 cannot read the default [sedtrails] section in a .mdu, as written in the copy in the .dia:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
This section should be read correctly. Alternatively it could be included in a
comments
field, as is done for the [veg] section.Screenshots
Version info (please complete the following information):
The text was updated successfully, but these errors were encountered: