620: Add support for optional [sedtrails] research section. #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRVermeulenDeltares
approved these changes
Jun 17, 2024
Comment on lines
+895
to
+906
| alias="sedtrailsgrid", | ||
| ) | ||
| research_sedtrailsanalysis: Optional[str] = Field( | ||
| "Sedtrails analysis. Should be all, transport, flowvelocity or soulsby.", | ||
| alias="sedtrailsanalysis", | ||
| ) | ||
| research_sedtrailsinterval: Optional[str] = Field( | ||
| "Sedtrails output times (s), interval, starttime, stoptime (s), if starttime, stoptime are left blank, use whole simulation period.", | ||
| alias="sedtrailsinterval", | ||
| ) | ||
| research_sedtrailsoutputfile: Optional[str] = Field( | ||
| "Sedtrails time-avgd output file.", alias="sedtrailsoutputfile" |
There was a problem hiding this comment.
Qua capitals, denk ik dat de aliases conform de kernel code zouden moeten zijn:
SedtrailsGridSedtrailsAnalysisSedtrailsIntervalSedtrailsOutputFile
There was a problem hiding this comment.
Zelfde antwoord als hierboven! :)
veenstrajelmer
approved these changes
Jun 24, 2024
# Conflicts: # hydrolib/core/dflowfm/research/models.py # tests/dflowfm/test_research.py
|
|
Tested and works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.