Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find active cells with idomain > 0 instead of idomain == 1 #1376

Closed
JoerivanEngelen opened this issue Jan 10, 2025 · 0 comments · Fixed by #1377
Closed

Find active cells with idomain > 0 instead of idomain == 1 #1376

JoerivanEngelen opened this issue Jan 10, 2025 · 0 comments · Fixed by #1377
Assignees
@JoerivanEngelen
Labels
bug Something isn't working

Comments

@JoerivanEngelen
Copy link
Contributor

JoerivanEngelen commented Jan 10, 2025 •
edited
Loading

The LHM apparently has > 1000 cells where IDOMAIN == 2. I noticed that wells located in these cells get masked away. For both iMOD5 as well as MODFLOW 6, IDOMAIN > 0 means active cell. iMOD Python, however, enforces/assumes IDOMAIN == 1, but we don't actually validate this.

I think it is more user friendly to support IDOMAIN > 0. A quick search showed that we only have a few files where active is computed as idomain == 1, so it appears to be low hanging fruit.
@JoerivanEngelen JoerivanEngelen added the bug Something isn't working label Jan 10, 2025
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Jan 10, 2025
@JoerivanEngelen JoerivanEngelen self-assigned this Jan 10, 2025
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🏗 In Progress in iMOD Suite Jan 10, 2025
@JoerivanEngelen JoerivanEngelen changed the title [Bug] - Find active cells with idomain > 0 instead of idomain == 1 Find active cells with idomain > 0 instead of idomain == 1 Jan 10, 2025
@JoerivanEngelen JoerivanEngelen mentioned this issue Jan 10, 2025
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 13, 2025
@JoerivanEngelen
Issue #1376 active idomain larger than zero (#1377)
ae03531 
Fixes #1376 

# Description
This aligns the way we find active cells, consistently with MODFLOW6: 
idomain > 0 is now the active domain, instead of idomain == 1. I updated
some model fixtures to have idomain = 2 to see if stuff like masking
works now for idomain == 2. Furthermore, I tried my best to update all
docstrings.

# Checklist

- [x] Links to correct issue
- [x] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [x] Unit tests were added
- [ ] **If feature added**: Added/extended example
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in iMOD Suite Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoerivanEngelen JoerivanEngelen

Labels
bug Something isn't working
Projects
iMOD Suite
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #1376 active idomain larger than zero Deltares/imod-python
1 participant
@JoerivanEngelen