Issue #1376 active idomain larger than zero #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manangka
approved these changes
Jan 13, 2025
imod/mf6/disv.py
Outdated
| idomain: array of integers (xu.UgridDataArray) | ||
| Indicates the existence status of a cell. If the idomain value for a |
There was a problem hiding this comment.
Don't we use active instead existence throughout our code?
Edit:
Ah nvm. In model.py you added clear definitions:
1 : active
=0 : inactive
<0 : vertical passthrough
|
JoerivanEngelen
deleted the
issue_#1376_active_idomain_larger_than_zero
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1376
Description
This aligns the way we find active cells, consistently with MODFLOW6:
idomain > 0 is now the active domain, instead of idomain == 1. I updated some model fixtures to have idomain = 2 to see if stuff like masking works now for idomain == 2. Furthermore, I tried my best to update all docstrings.
Checklist
Issue #nr, e.g.Issue #737