Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests run for too long leading to timeouts #563

Closed
2 tasks done
Carsopre opened this issue Aug 30, 2024 · 0 comments
Closed
2 tasks done

Tests run for too long leading to timeouts #563

Carsopre opened this issue Aug 30, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@Carsopre
Copy link
Collaborator

Ra2ce version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of Ra2ce in master here.

Reproducible example

https://dpcbuild.deltares.nl/buildConfiguration/Ra2ce_Ra2ceContinuousDelivery_RunAllTests/4423291?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildDeploymentsSection=false&expandBuildChangesSection=true&expandBuildProblemsSection=true

https://dpcbuild.deltares.nl/buildConfiguration/Ra2ce_Ra2ceContinuousIntegrationBuild_RunSlowAndExternalTestsPytestXdist/4417918?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildDeploymentsSection=false&expandBuildChangesSection=true&expandBuildProblemsSection=true

Current behaviour

Since recent versions the code hangs on where it use to run relatively fast(er).

Desired behaviour

Tests do not timeout.

Additional context

No response

@Carsopre Carsopre added this to the Launch 2024 milestone Aug 30, 2024
@Carsopre Carsopre added bug Something isn't working enhancement New feature or request labels Aug 30, 2024
@Carsopre Carsopre self-assigned this Aug 30, 2024
@Carsopre Carsopre linked a pull request Aug 30, 2024 that will close this issue
7 tasks
Carsopre added a commit that referenced this issue Aug 30, 2024
## Issue addressed
Solves #563 

## Code of conduct
- [x] I HAVE NOT added sensitive or compromised (test) data to the
repository.
- [x] I HAVE NOT added vulnerabilities to the repository.
- [x] I HAVE discussed my solution with (other) members of the RA2CE
team.

## What has been done?
- Moved logic in protocol as static method in the `Segmentation` class.
Not ideal, but better than before.
- Modified test `network.ini` files so that their segmentation length
property is `100` (meters) rather than `0.0001` which makes it way
longer to compute.

### Checklist
- [x] Code is formatted using our custom `black` and `isort`
definitions.
- [x] Tests are either added or updated.
- [x] Branch is up to date with `master`.
- [x] Updated documentation if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants