Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/563 tests run for too long leading to timeouts #565

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Chore/563 tests run for too long leading to timeouts #565

merged 2 commits into from
Aug 30, 2024

Conversation

Carsopre
Copy link
Collaborator

Issue addressed

Solves #563

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

  • Moved logic in protocol as static method in the Segmentation class. Not ideal, but better than before.
  • Modified test network.ini files so that their segmentation length property is 100 (meters) rather than 0.0001 which makes it way longer to compute.

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

@Carsopre Carsopre merged commit 6bd6ce7 into master Aug 30, 2024
4 of 5 checks passed
@Carsopre Carsopre deleted the chore/563-tests-run-for-too-long-leading-to-timeouts branch August 30, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Carsopre