a basic datacollection simulator #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be good to go now |
Anthchirp
reviewed
Oct 12, 2021
Comment on lines
+78
to
+80
| @abstractmethod | ||
| def run(self, *args, **kwargs): | ||
| pass |
There was a problem hiding this comment.
Do we really need an abstract class for something that only has a single implementation?
There was a problem hiding this comment.
The idea is that in future you might want to simulate something other than a data collection. There are plenty of things populated by the acquisition client that are not handled by ispyb-api. For example a RobotAction is not a DataCollection, nor is an XFEFluoresenceSpectrum. Would need a bit of tinkering on the arg parser to select the relevant class but should be flexible enough
|
Try again... |
|
Ping |
|
Without any further feedback im gonna merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not as full featured as dc_sim but lets folk outside of dls simulate a data collection and trigger mimas.