Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a basic datacollection simulator #163
a basic datacollection simulator #163
Changes from all commits
ff99a1d
0082f62
fb83739
2bab7d2
f0b52e3
3fa225f
7d2bfe4
cc57ee8
776ec65
94eac9a
bb28539
9cd12d6
12c7747
68d656f
a495af3
b767a8a
322fe16
96c5bb6
7e0434d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need an abstract class for something that only has a single implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is that in future you might want to simulate something other than a data collection. There are plenty of things populated by the acquisition client that are not handled by ispyb-api. For example a RobotAction is not a DataCollection, nor is an XFEFluoresenceSpectrum. Would need a bit of tinkering on the arg parser to select the relevant class but should be flexible enough