forked from qmk/qmk_firmware
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix qmk#156: clear weak mods on every key press
- new macro_mods bit field for mods applied by macros - weak_mods now only used for ACT_{L,R}MODS (i.e. LSFT, RSFT, LCTL etc.) - clear the _weak_ mods on every key *pressed* such that LSFT etc. can no more interfere with the next key
- Loading branch information
1 parent
7d3ebd7
commit b7a81f0
Showing
4 changed files
with
23 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7a81f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually have a much more complete solution for qmk#156 that I am going to reveal after Jack finishes shipping out all the Massdrop orders. It makes it possible for layouts like Programmer Dvorak to be implemented seamlessly.
b7a81f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eric-L-T Couldn't you already share it already? I guess you didn't test it yet but that would be more convenient for discussing it ;-)
I suppose this also relates to qmk#148, which discusses Programmer Dvorak.
b7a81f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've actually done a lot of testing and my findings have allowed me to make my solution much better than it originally was. It's kind of hard to explain. Do you mind waiting?
b7a81f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DidierLoiseau Jack wrote me that he doesn't have enough time to look at what I've done at the moment because he's busy fulfilling the last of the Massdrop orders.
b7a81f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eric-L-T we should continue the discussion on PR qmk#188, Jack has already posted a comment there. It will become confusing otherwise :-)
I wonder why he asked that though, there are lots of people contributing ATM, and even if he does not have the time now I think it's always useful to create PR's as soon as they are ready and have a visible backlog.
b7a81f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's your rationale for creating
macro_mods
? I read through qmk#156 and I didn't quite understand.b7a81f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that this solution is causing some issues such as qmk#221. Do you want me to send you my solution in a pull request? It sorta depends on qmk#182, though.
b7a81f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eltang I think you should definitely make your PR against @jackhumbert's repo, you will get more feedback there. There are already many ongoing PR now so I don't see why yours should wait. Even if Jack does not have the time to review it now it won't hurt to have it already.
Anyway I'd be glad to have a look at your changes even if you don't create a PR yet. Is it in your modifier-release-fix branch?
b7a81f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code's not on GitHub yet. I'll try to upload it in a bit.