Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add support for AVIF images #389

Closed
ccvelandres opened this issue Jan 18, 2021 · 2 comments
Closed

[Feature Request] Add support for AVIF images #389

ccvelandres opened this issue Jan 18, 2021 · 2 comments
Labels
enhancement homebrew reader

Comments

@ccvelandres
Copy link

Add support for AVIF images. AVIF images in archives are not detected when adding new archives.
@ccvelandres ccvelandres changed the title Add support for AVIF images [Feature Request] Add support for AVIF images Jan 18, 2021
@Difegue
Copy link
Owner

Difegue commented Jan 18, 2021 •
edited
Loading

Support is easy enough to add on my end(and seems to work on browsers), but there are some gotchas:

  • AVIF support in ImageMagick is from v7 onwards: The current homebrew formula still uses v6 and would need an upgrade.
  • A check should be done in the Dockerfile as well to make sure the magick we're using on Alpine has AVIF support builtin. (Debian has it, so that should probably be alright)
  • Mobile browsers have spotty support for AVIF at the time being, but I don't think that's too much of an issue - users should expect that stuff when using newfangled image formats. 😁
  • Tachiyomi and other external clients will probably choke on those images for the time being? Not sure.

Bonus good news: since magick uses libheif for both AVIF and HEIF, I could probably add support for both formats at once once this is cleared up.

Difegue added a commit that referenced this issue Feb 28, 2021
@Difegue
(#389) Update magick to v7 in homebrew
1f7a413
Difegue added a commit that referenced this issue Feb 28, 2021
@Difegue
(#389) Add libheif to Dockerfile and unlock avif/heif support
65e569c
@Difegue
Copy link
Owner

Difegue commented Feb 28, 2021

I've unlocked both HEIF/HEIC and AVIF as of the latest commit. Some caveats:

HEIC

HEIC support in thumbnails should work even with Magick 6.9.

There's absolutely no browser support (lmao), so if you want to display HEIC content in the web reader I suggest using the "Resize Images" feature to convert them to jpg with magick dynamically:
image

AVIF

AVIF support in thumbnails needs ImageMagick v7 with libheif installed.

MS Edge doesn't support displaying the format, Chrome(supposedly) does.
You may encounter display issues on Firefox if you don't set the matching pref in about:config:
image

@Difegue Difegue closed this as completed Feb 28, 2021
Difegue added a commit that referenced this issue Mar 11, 2021
@Difegue @ImgBotApp
@CirnoT @imgbot
LANraragi Release 0.7.7
8c670c5 
* [ImgBot] Optimize images

*Total -- 955.60kb -> 756.84kb (20.8%)

/tools/Documentation/.gitbook/assets/ratings.png -- 131.97kb -> 86.23kb (34.66%)
/tools/Documentation/.gitbook/assets/index.png -- 193.08kb -> 129.82kb (32.76%)
/tools/Documentation/.gitbook/assets/archive_thumb.jpg -- 630.55kb -> 540.78kb (14.24%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

* Do not show page select when there are no results

* Also hide table header

* Update buildx action to the official Docker one

* Update s6

* Update less, the alpine package doesn't seem to have s6-overlay-preinit yet?

* pin s6 alpine package

* Rollback alpine base for now

* Fix ARM builds (#394)

* Update push-continous-delivery.yml

* Update release-delivery.yml

* Update push-continous-delivery.yml

* Update push-continous-delivery.yml

* Improve visibility when sorting table columns + fix being able to put whitespace as a custom column

* Fix context menu applying to overlays

* (#374) Remove cooldown on auto-plugin as it's basically useless

* Fix memory leak caused by the Parallel::Loops/Storable combo in the Search API

* Add some basic retrying logic on our first Redis connection
This avoids dying unnecessarily if Redis takes a while to load into memory.

* Accept "false" properly for pinned on category creation

* Also fix the update_cat endpoint

* Remove favtagmigration script

* Add a simple GET to /api/categories/:id

* (#335) Reading progression is now server-side!

* Fix method for progress in docs

* Fix docs thanks for nothing gitbook

* (#385) (#397) Remove the built-in Auto-Tag feature in favor of a Filename parsing plugin

* Fix tests

* Avoid uninitialized warnings if there's no progress/pagecount in DB

* Add a pageread stat and actually use the package.json description 'cause why not

* Remove unnecessary datatables cdn include

* (#282) Rewrite Shinobu filemap so it relies on Redis and keeps state between restarts

* (#405) Add job + api req to regen all thumbnails
Also remove redis loading timeout for REALLY BIG dataset

* (#410) NFC all the things

* Add fa-solid-900.woff2 to the vendor deps
so that browsers finally shut up about it, also added fa-regular

* Fix submenu arrow colors in the various themes

* autism

* Add an API endpoint to return which categories an ID belongs to

* (#375) Rework context menu so it uses the new endpoint to remove archives from categories

* More doc details on the reading progression API

* Some more documentation fixes

* MORE Documentation updates gee

* (#412) Add autofocus to the password input in login

* (#397) Add a check to RegexParse to avoid putting numbers as languages

* (#414) Fix regexparse not decoding the filesystem path + decode log in minion upload for extra clarity

* (#389) Update magick to v7 in homebrew

* backport changes from homebrew-core
those guys write ruby way better than I do

* Fix brew test runs

* (#389) Add libheif to Dockerfile and unlock avif/heif support

* Don't recommend homebrew for linux since it doesn't work out of the box atm

* Add Mojolicious::Plugin::Status when running in debug mode

* Update docs to fix wrong json examples

* Stop using a static secret for mojo's cookie signatures

* Remove the auto-plugin toggle and matching pref
It's a bit unnecessary considering plugins have to be toggled manually anyways.

* Rework Plugin Configuration page a bit further

* (#267) Make the thumbnail folder location an option

* [ImgBot] Optimize images (#416)

/tools/Documentation/.gitbook/assets/thumbchange.png -- 55.64kb -> 36.35kb (34.67%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>

* Add some JS to migrate local reading progression

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com>
Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com>
@ghost ghost mentioned this issue Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement homebrew reader
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Difegue @ccvelandres