-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZE Plugin recognizes "gid" value as language tag #397
Comments
You can see in the last line of the plugin log that it only returns the following tags to LRR: I suspect the |
Yes, that seems to be the case. I do believe an included json should rank higher in the priority list tho. Why a string of numbers gets recognized as a language is also beyond me. |
Well, there's not really a priority list to speak of, the current workflow mostly just pools everything that's enabled. ¯\_(ツ)_/¯ |
Hmm, a few days later and I tried to add galleries again but no language tag is being parsed no matter what I do. Auto-Tag is disabled of course. Tried with both Auto-Plugin and manual Batch Tagging. |
"Save archive title" instructs the plugin to overwrite the recorded title for the archive in the database with the one found in the json file. |
Something slightly different is happening for me. (Auto-Tag is off btw)
As I understand it, with ON I should be getting the Json title while in reality I'm getting a parsed one without the extra stuff like event, artist, parody etc., while OFF is working correctly. Also I noticed that the eze plugin is working slightly differently from the e-hentai plugin. The e-hentai plugin includes these additional tags: "category", "timestamp" and "uploader". Granted, the timestamp and uploader tags are optional, but I think the eze plugin should include this as well. |
I forgot about that, but the eze plugin does use similar regex parsing to only save the title without the extra metadata. |
* [ImgBot] Optimize images *Total -- 955.60kb -> 756.84kb (20.8%) /tools/Documentation/.gitbook/assets/ratings.png -- 131.97kb -> 86.23kb (34.66%) /tools/Documentation/.gitbook/assets/index.png -- 193.08kb -> 129.82kb (32.76%) /tools/Documentation/.gitbook/assets/archive_thumb.jpg -- 630.55kb -> 540.78kb (14.24%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> * Do not show page select when there are no results * Also hide table header * Update buildx action to the official Docker one * Update s6 * Update less, the alpine package doesn't seem to have s6-overlay-preinit yet? * pin s6 alpine package * Rollback alpine base for now * Fix ARM builds (#394) * Update push-continous-delivery.yml * Update release-delivery.yml * Update push-continous-delivery.yml * Update push-continous-delivery.yml * Improve visibility when sorting table columns + fix being able to put whitespace as a custom column * Fix context menu applying to overlays * (#374) Remove cooldown on auto-plugin as it's basically useless * Fix memory leak caused by the Parallel::Loops/Storable combo in the Search API * Add some basic retrying logic on our first Redis connection This avoids dying unnecessarily if Redis takes a while to load into memory. * Accept "false" properly for pinned on category creation * Also fix the update_cat endpoint * Remove favtagmigration script * Add a simple GET to /api/categories/:id * (#335) Reading progression is now server-side! * Fix method for progress in docs * Fix docs thanks for nothing gitbook * (#385) (#397) Remove the built-in Auto-Tag feature in favor of a Filename parsing plugin * Fix tests * Avoid uninitialized warnings if there's no progress/pagecount in DB * Add a pageread stat and actually use the package.json description 'cause why not * Remove unnecessary datatables cdn include * (#282) Rewrite Shinobu filemap so it relies on Redis and keeps state between restarts * (#405) Add job + api req to regen all thumbnails Also remove redis loading timeout for REALLY BIG dataset * (#410) NFC all the things * Add fa-solid-900.woff2 to the vendor deps so that browsers finally shut up about it, also added fa-regular * Fix submenu arrow colors in the various themes * autism * Add an API endpoint to return which categories an ID belongs to * (#375) Rework context menu so it uses the new endpoint to remove archives from categories * More doc details on the reading progression API * Some more documentation fixes * MORE Documentation updates gee * (#412) Add autofocus to the password input in login * (#397) Add a check to RegexParse to avoid putting numbers as languages * (#414) Fix regexparse not decoding the filesystem path + decode log in minion upload for extra clarity * (#389) Update magick to v7 in homebrew * backport changes from homebrew-core those guys write ruby way better than I do * Fix brew test runs * (#389) Add libheif to Dockerfile and unlock avif/heif support * Don't recommend homebrew for linux since it doesn't work out of the box atm * Add Mojolicious::Plugin::Status when running in debug mode * Update docs to fix wrong json examples * Stop using a static secret for mojo's cookie signatures * Remove the auto-plugin toggle and matching pref It's a bit unnecessary considering plugins have to be toggled manually anyways. * Rework Plugin Configuration page a bit further * (#267) Make the thumbnail folder location an option * [ImgBot] Optimize images (#416) /tools/Documentation/.gitbook/assets/thumbchange.png -- 55.64kb -> 36.35kb (34.67%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> * Add some JS to migrate local reading progression Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com> Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com>
Using the eze plugin on a 7z archive including an info.json will result in the language tag being wrongly displayed. Instead of the language, Japanese, being shown, the "gid" value, 1093785, will be displayed.
info.txt
Version
LRR for Windows 10 0.7.6
Logs
LANraragi log
Plugin log
The text was updated successfully, but these errors were encountered: