Feature/416 Added support for multiple call to actions per project.

[Arilith]

Description

Added support for multiple call to actions per project, with the limits and conditions discussed in #440 .

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist

• My code follows the style guidelines of this project
• I did not update API Controllers, if I did, I added/changed Postman tests
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I updated the changelog with an end-user readable description
• I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

Add a single call to action

1. Add a new project, by posting to "/api/Project".
2. Make sure you only include one call to action.
3. Make sure the "optionvalue" of the call to action is correct, look at the "CallToActionOptions" table for possible correct values.
4. After the request succeeded, you should be able to see the project with the call to action by going to "/api/Project/"

Add Multiple call to actions

1. Add a new project, by posting to "/api/Project".
2. Make sure you include multiple call to actions.
3. Make sure the "optionvalue" of all call to actions is correct, look at the "CallToActionOptions" table for possible correct values. (Preferably pick multiple different values)
4. After the request succeeded, you should be able to see the project with the call to action by going to "/api/Project/"

Add call to action with invalid action value

1. Add a new project, by posting to "/api/Project".
2. Make sure you include at least one call to action.
3. Make sure the "optionvalue" of all call to actions is incorrect, for example "INCORRECTACTION"
4. You should receive a bad request (400) error, with an instance-id of "40EE82EB-930F-40C8-AE94-0041F7573FE9"

Add call to action with duplicate action values

1. Add a new project, by posting to "/api/Project".
2. Make sure you include at least two call to actions.
3. Make sure the "optionvalue" of at least two call to actions are the same and correct, for example "Join today"
4. You should receive a bad request (400) error, with an instance-id of "D2C8416A-9C55-408B-9468-F0E5C635F9B7"

Add more than four call to actions

1. Add a new project, by posting to "/api/Project".
2. Make sure you include at least five call to actions.
3. Make sure the "optionvalue" of all call to actions are DISTINCT and CORRECT for example "Join today", "Provide feedback", "Apply now", "Collaborate with us", "More information"
4. You should receive a bad request (400) error, with an instance-id of "E780005D-BBEB-423E-BA01-58145D3DBDF5"

Link to issue

Closes: #416

[RubenFricke]

Looks good Tristan! Code looks code, it's amazing how fast you were able to get familiar with the codebase. Good job! I have one small remark (nothing spectacular). I noticed that I'm able to add 2 call to actions with the same option-value while in the create function this is not possible. Could you take a look into this please?

Overall it looks really good, keep up the good work.

[Arilith]

Looks good Tristan! Code looks code, it's amazing how fast you were able to get familiar with the codebase. Good job! I have one small remark (nothing spectacular). I noticed that I'm able to add 2 call to actions with the same option-value while in the create function this is not possible. Could you take a look into this please?

Overall it looks really good, keep up the good work.

I will fix that as soon as possible, thanks for the remark!

[niraymak]

Please note that the frontend is not yet ready for this PR to be merged. See comment: DigitalExcellence/dex-frontend#454 (comment)
I guess we should merge both PR's at the same time.

[niraymak]

Only one minor change requested!

Nice first PR 👍

[waltersajtos]

Shouldn't this check if there are duplicate OptionValues instead of Values? Option value is the type of call to action (e.g "Join today") and value is the url ("https://github.com/digitalexellence/dex-frontend"). Right now it's not possible to link the same page twice, I don't think that that is the behaviour we want.

[Arilith]

Well, as this is the second pull-request for this issue, it may be a little unclear. But in the previous PR #440 it was asked to also check for the values. So currently it's not possible to add any duplicate buttons as that could be unclear and it's not possible to add multiple of the same URL's.

[waltersajtos]

I think people should be able to add the same url on different buttons, maybe @RubenFricke & @niraymak can give their opinion on this?

[RubenFricke]

In my opinion, the URL can be the same in multiple added call to actions. However, you should not be able to add 2 the same call to action (I think I also mentioned this in the other pull request, but I can't remember anything said about checking on the values). @niraymak do you have any opinions about this?

[niraymak]

I agree with you. @RubenFricke

[Arilith]

Good, I'll update this today.

[niraymak]

Will approve when frontend is ready for it. :)

[waltersajtos]

Just finished the front-end implementation, everything worked as expected. Good work!

regreg