Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutliple call to action options #454

Closed
waltersajtos opened this issue Apr 3, 2021 · 5 comments · Fixed by #533
Closed

Mutliple call to action options #454

waltersajtos opened this issue Apr 3, 2021 · 5 comments · Fixed by #533
Assignees
Labels
priority Only assign this label if it's asked to assign this label

Comments

@waltersajtos
Copy link
Member

waltersajtos commented Apr 3, 2021

Is your feature request related to a problem? Please describe.
When the project detail page's design was made, we decided it would make sense to have multiple call-to-action buttons. With the current implementation, this is not possible

Describe the solution you'd like
In the current implementation, the call-to-action option is selected with a radio button. These should be changed to checkboxes and change the SelectedCallToActionOption from Number to Number[]. The connection with the backend should also be changed.

This issue is blocked until DigitalExcellence/dex-backend#416 is completed

@RubenFricke
Copy link
Member

Store the icon in the backend as well to keep the icons scalable.

@niraymak niraymak added the priority Only assign this label if it's asked to assign this label label May 25, 2021
@niraymak
Copy link
Member

niraymak commented May 25, 2021

Currently there is a PR open on the backend which makes it possible to assign multiple call to actions to one project.
DigitalExcellence/dex-backend#440

This PR breaks the current implementation of showing the call to action. This is because the frontend expects one object instead of an array. If we want to merge the PR on the backend we should at least make it possible to show the array of call to actions and send an when inserting / updating a project.
But preferably it would also be possible to assign multiple call to actions in both the project wizard and the project edit modal.

We should also check what the maximum amount of linked call to actions should be.

@waltersajtos
Copy link
Member Author

@RubenFricke, @niraymak, or @Arilith I assume this PR does not implement storing the cta icons in the backend right? Is this still planned or has it been dropped? I still think it doesn't add that much value, because the current designs don't really allow adding or removing cta options.

@niraymak
Copy link
Member

@RubenFricke, @niraymak, or @Arilith I assume this PR does not implement storing the cta icons in the backend right? Is this still planned or has it been dropped? I still think it doesn't add that much value, because the current designs don't really allow adding or removing cta options.

I guess adding cta icons could have added value. For example if you want a mail icon on your "join today" button. This could be something for next semester. Maybe we can open a new issue for the above?

But for this PR it is only necessary to:

  • show multiple cta at the details page
  • make it possible to add multiple cta in the wizard
  • make it possible to add multiple cta in the edit project page.

@waltersajtos
Copy link
Member Author

Okay, I will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Only assign this label if it's asked to assign this label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants