-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutliple call to action options #454
Comments
Store the icon in the backend as well to keep the icons scalable. |
Currently there is a PR open on the backend which makes it possible to assign multiple call to actions to one project. This PR breaks the current implementation of showing the call to action. This is because the frontend expects one object instead of an array. If we want to merge the PR on the backend we should at least make it possible to show the array of call to actions and send an when inserting / updating a project. We should also check what the maximum amount of linked call to actions should be. |
@RubenFricke, @niraymak, or @Arilith I assume this PR does not implement storing the cta icons in the backend right? Is this still planned or has it been dropped? I still think it doesn't add that much value, because the current designs don't really allow adding or removing cta options. |
I guess adding cta icons could have added value. For example if you want a mail icon on your "join today" button. This could be something for next semester. Maybe we can open a new issue for the above? But for this PR it is only necessary to:
|
Okay, I will look into it. |
Is your feature request related to a problem? Please describe.
When the project detail page's design was made, we decided it would make sense to have multiple call-to-action buttons. With the current implementation, this is not possible
Describe the solution you'd like
In the current implementation, the call-to-action option is selected with a radio button. These should be changed to checkboxes and change the
SelectedCallToActionOption
fromNumber
toNumber[]
. The connection with the backend should also be changed.This issue is blocked until DigitalExcellence/dex-backend#416 is completed
The text was updated successfully, but these errors were encountered: