Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multiple call to actions #533

Merged
merged 33 commits into from
Jun 29, 2021

Conversation

waltersajtos
Copy link
Member

@waltersajtos waltersajtos commented Jun 22, 2021

Description

In the original designs of the detail page, it was possible to add multiple call-to-action options. This pull request will implement these designs and functionality.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

  1. Add a project with 3 call-to-action.
  2. Go to the overview page and check if the project has the call to action buttons with the URLs.
  3. Edit your project and change a url and remove a call to action button.
  4. Validate the changes came through.

Link to issue

Closes: #454

Copy link
Member

@niraymak niraymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project categories don't show as active anymore on the edit page.
image

Styling beneath the call to actions on the edit page seemed a bit odd. Is the styling on the buttons updated on purpose?
image

waltersajtos and others added 8 commits June 28, 2021 19:55
# Conflicts:
#	src/app/models/resources/project-add.ts
#	src/app/modules/project/details/details.component.scss
#	src/app/modules/project/edit/edit.component.ts
#	src/app/modules/project/project.module.ts
#	src/app/services/wizard.service.ts
…ns' into feature/454-multiple-calltoactions

# Conflicts:
#	src/app/modules/project/edit/edit.component.ts
niraymak
niraymak previously approved these changes Jun 29, 2021
Copy link
Member

@niraymak niraymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

…ns' into feature/454-multiple-calltoactions

# Conflicts:
#	src/app/modules/project/call-to-actions-edit/call-to-actions-edit.component.scss
Copy link
Member

@niraymak niraymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@RubenFricke RubenFricke merged commit 2f3d2c5 into develop Jun 29, 2021
@RubenFricke RubenFricke deleted the feature/454-multiple-calltoactions branch June 29, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutliple call to action options
3 participants