-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/458-edit-and-delete-button-always-shown #459
Bugfix/458-edit-and-delete-button-always-shown #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks! The only thing that doesn't work anymore is editing/deleting projects as admin/data officer. I think those admins should be able to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works for the admin now, great! My last nitpick, let's add some small logic for the data officer so everything will work flawlessly 😉 !
…n-always-shown' into bugfix/458-edit-and-delete-button-always-shown
As Ruben said it is not possible yet for the data officer to edit a project which is owned by a user of the same institution. |
Description
It looks like this problem was caused by some failed merge conflict. The correct code was there but was blocked by the old code.
Type of change
Checklist
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.
Link to issue
Closes: #458
Closes: #445