Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/458-edit-and-delete-button-always-shown #459

Merged
merged 12 commits into from
Apr 28, 2021

Conversation

waltersajtos
Copy link
Member

@waltersajtos waltersajtos commented Apr 8, 2021

Description

It looks like this problem was caused by some failed merge conflict. The correct code was there but was blocked by the old code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

  1. Go to the project overview page
  2. Click a project
  3. Check if there is a cog icon in the top right

Link to issue

Closes: #458
Closes: #445

@waltersajtos waltersajtos self-assigned this Apr 10, 2021
@waltersajtos waltersajtos added the bug Something isn't working label Apr 10, 2021
@waltersajtos waltersajtos changed the title Bugfix/458 edit and delete button always shown Bugfix/458-edit-and-delete-button-always-shown Apr 13, 2021
Copy link
Member

@RubenFricke RubenFricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks! The only thing that doesn't work anymore is editing/deleting projects as admin/data officer. I think those admins should be able to do this.

Copy link
Member

@RubenFricke RubenFricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for the admin now, great! My last nitpick, let's add some small logic for the data officer so everything will work flawlessly 😉 !

src/app/modules/project/details/details.component.ts Outdated Show resolved Hide resolved
src/app/modules/project/details/details.component.ts Outdated Show resolved Hide resolved
@niraymak
Copy link
Member

As Ruben said it is not possible yet for the data officer to edit a project which is owned by a user of the same institution.
Please create a new issue.
No further comments! Good job!

niraymak
niraymak previously approved these changes Apr 26, 2021
RubenFricke
RubenFricke previously approved these changes Apr 26, 2021
@waltersajtos waltersajtos dismissed stale reviews from RubenFricke and niraymak via 599a0d8 April 26, 2021 16:51
@waltersajtos waltersajtos merged commit 4c5f0d1 into develop Apr 28, 2021
@waltersajtos waltersajtos deleted the bugfix/458-edit-and-delete-button-always-shown branch April 28, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit- & delete-project button always get showed Hide settings icon on project that are not yours
3 participants