Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Travel rules not up to date" / "Reiseregeln nicht aktuell": Unfortunately the last update failed… #98

Closed
3 tasks done
Jo-Achim opened this issue Nov 4, 2021 · 16 comments
Labels
bug Something isn't working

Comments

@Jo-Achim
Copy link

Jo-Achim commented Nov 4, 2021

Avoid duplicates

Technical details

  • Device name: Not relevant. (CovPass v1.12.0: Samsung Galaxy Note 10, SM-N970F/DS /// CovPass v 1.11.1: Nokia 7.2, TA-1196)
  • OS version: Not relevant. (Samsung: Android 11 (One UI 3.1) with Android security update: 01. Oktober 2021 /// Nokia: Android 10 with Android security update: September 1st, 2021)
  • App version: 1.12.0

Describe the bug

When calling CovPass v1.12.0 and calling "Check validity >", the following message is displayed in the "Check validity" dialog:

"Travel rules not up to date" ...
Screenshot_20211103-232151_CovPass_2

It seems to me that the app makes no attempt to update, because the notice is displayed immediately, despite the presence of WiFi.

In comparison to the previous version 1.11.1, the following is initially displayed if the above procedure is the same:
Screenshot_20211104-004356_2

and then a few seconds later:
Screenshot_20211104-004409_2

Steps to reproduce the issue

Make sure that the smartphone has an internet connection - in my case only via WLAN! (One smartphone (Samsung) is not allowed to access the internet via mobile phone provider, the second one (Nokia) does not have a SIM card.)

  1. Start CovPass v1.12.0
  2. Tap on "Check Validity >"
  3. The v1.12.0 dialog shown above is displayed - without any time delay.

Expected behaviour

Ensuring that every time CovPass v1.12.0 is started, the 'out of date data for the entry rules' are updated via the existing Internet.

Cross reference: ["CovPass Check": Offline mode & WLAN]: "Internet connection required" although available ....
(Please do not be surprised about the version numbers of CovPass / CovPassCheck mentioned in the cross-reference, which are 'normal'; see Repeated version jumps / incomprehensible numbering of the versions in CovPass & CovPassCheck ....)

Possible Fix

Implementation of the update mechanism for the travel rules from version 1.11.1 or other corrections in the next version of CovPass.

Additional context

Open / not tested: similar behavior in CovPassCheck v 1.12.0.


PS: If helpful, a supplement for the above Samsung data:

CovPassCheck v.1.12.0 shows:

  • Offline mode available
  • List of certificate issuers: 11/03/2021 6:09 pm
  • Inspection rules: 11/02/2021 6:15 pm.
@Jo-Achim Jo-Achim added the bug Something isn't working label Nov 4, 2021
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Nov 4, 2021

Can't reproduce this under iOS.

@Jo-Achim
Copy link
Author

Jo-Achim commented Nov 6, 2021

Update: Since yesterday afternoon (11/05/2021), round about 36 hours after update to version 1.12.0, the message "Travel rules not up to date" / "Reiseregeln nicht aktuell" has disappeared without further ado.

Cross reference: CovPassCheck shows warning "Check date and time".

Something is not going well.

@Jo-Achim
Copy link
Author

Jo-Achim commented Nov 7, 2021

Info:
Internet connection via WLAN available.

CovPass 1.12.0:
"Travel rules not up to date" / "Reiseregeln nicht aktuell" again: 11/08/2021 ~00:0x am (or earlier).

11/08/2021 ~00:08 am: no more corresponding message.


CovPassCheck 1.12.0:
Offline-Mode: Internet connection required.
List of Certificate Issuers: 11/06/2021 09:54 pm
Inspection rules: 11/08/2021 00:14 am.

Offline mode: available.
List of certificate issuers: 11/08/2021 00:20 am
Inspection rules: 11/08/2021 00:14 am.

@Jo-Achim
Copy link
Author

Today (11/13/2021 06:38 pm):
"Travel rules not up to date" / "Reiseregeln nicht aktuell" again.

Something goes wrong!

See cross reference from today: #97 (comment)!

@MikeMcC399
Copy link

@Jo-Achim
It sounds like you have connectivity problems from your device, especially if there are not any similar reports from other users.

Are you running any firewall software on the device or are you behind a firewall?

@Jo-Achim
Copy link
Author

Jo-Achim commented Nov 15, 2021

@MikeMcC399,

yes, there is a firewall involved; NetGuard v2.298 / v2.299 Pro with Ad-Blocker.

However, I would like to point out that ...

The same firewall with the same configuration is also installed on my test / comparison cell phone. So that I can say in comparison: Version 1.11.1 (red frame) and 1.12.0 behave differently under the same configurations. And since I suspect very similar mechanisms in CovPass and CovPassCheck...

Finally: CWA has not had any problems since then; see [INFO] URSACHE: 9002, Etwas ist schiefgelaufen. Timeout #998).


PS: Some informations about NetGuard v.2.299 (protocoll) - hope it helps:
CovPass v1.12.0 (de.rki.covpass.app) allowed (green):

  • T4 distribution.doc-rules.de/443
  • T4 de.dscg.ubirch.com/443

CovPassCheck v1.12.0 (de.rki.covpass.checkapp) allowed (green):

  • T4 de.dscg.ubirch.com/443
  • T4 distribution.doc-rules.de/443
  • U4 1.de.pool.ntp.org/123

(For both: Currently no blocked rules.)

@JilAuraya
Copy link

Hello Jo-Achim, thank you for pointing out this bug (and I apologize for the late response).
This will be fixed with the upcoming release of the CovPass app.

@Jo-Achim
Copy link
Author

@JilAuraya, thank you.

@Jo-Achim
Copy link
Author

Additional information:
Tonight the message "Travel rules not up to date" again.
Then I deleted the cache (via Settings, Apps, CovPass) from CovPass ... but the message stayed after restarting the app.

Then I deleted the cache again plus the data from CovPass. The result is hardly surprising: after all vaccination certificates were scanned again, the message was no longer available.

PS: WLAN was permanently available. According to the NetGuard protocol, there were no 'blocked' access attempts.

@timokoenig
Copy link
Member

As far as I can see, the worker to update the rules runs every 24 hours in the background. The message "Travel rules not up to date" gets displayed when the rules are older than 24 hours. Even when the requests do not get blocked by a firewall there is a small window where the message will appear due to the time it takes to update the rules. If there is an error and the worker goes into the exponential backoff this window might goes from a few minutes to a few hours.

@JilAuraya @pucherd I suggest to change the time to show the message to 36 or 48 hours. This way there is small buffer where the app has time to update the rules without suggesting that the app is out of date.

Another addition would be to show the actual error code when the background worker fails so that the user has a better indication whether something is wrong or not

@pucherd
Copy link
Contributor

pucherd commented Nov 20, 2021

Hi @timokoenig, we replaced all workers with "on-demand" requests (v1.13.1) which will be done on users interaction -> so each time the user lands in the card overview we will check if the rules are older than 24 hours.
But it is a good Idea to show the actual error code when the request fails.

@timokoenig
Copy link
Member

@pucherd that's great to hear! I guess that will mitigate some issues with the background tasks

@Jo-Achim
Copy link
Author

Thank you, @pucherd

..., we replaced all workers with "on-demand" requests (v1.13.1) which will be done on users interaction -> so each time the user lands in the card overview we will check if the rules are older than 24 hours. But it is a good Idea to show the actual error code when the request fails.

With the current version 1.13.2 the optional manual option "Update entry rules" is available.

@pucherd
Copy link
Contributor

pucherd commented Nov 24, 2021

Thank you for the feedback @Jo-Achim. Can we close this ticket?

@Jo-Achim
Copy link
Author

Yes, I close, since the alternative implementation via the manual update is also a good solution.
The other solution would of course have been, if there was any internet connection, to update the travel rules automatically every time the app was started. As probably in version 1.11.1.

@pucherd
Copy link
Contributor

pucherd commented Nov 25, 2021

@Jo-Achim the manual update is a alternative solution the travel rules will be updated each time the app is started (of course if the the last update is older than 24 hours).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants