-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] "Travel rules not up to date" / "Reiseregeln nicht aktuell": Unfortunately the last update failed… #98
Comments
Can't reproduce this under iOS. |
Update: Since yesterday afternoon (11/05/2021), round about 36 hours after update to version 1.12.0, the message "Travel rules not up to date" / "Reiseregeln nicht aktuell" has disappeared without further ado. Cross reference: CovPassCheck shows warning "Check date and time". Something is not going well. |
Info: CovPass 1.12.0: 11/08/2021 ~00:08 am: no more corresponding message. CovPassCheck 1.12.0: Offline mode: available. |
Today (11/13/2021 06:38 pm): Something goes wrong! See cross reference from today: #97 (comment)! |
@Jo-Achim Are you running any firewall software on the device or are you behind a firewall? |
yes, there is a firewall involved; NetGuard v2.298 / v2.299 Pro with Ad-Blocker. However, I would like to point out that ...
The same firewall with the same configuration is also installed on my test / comparison cell phone. So that I can say in comparison: Version 1.11.1 (red frame) and 1.12.0 behave differently under the same configurations. And since I suspect very similar mechanisms in CovPass and CovPassCheck... Finally: CWA has not had any problems since then; see [INFO] URSACHE: 9002, Etwas ist schiefgelaufen. Timeout #998). PS: Some informations about NetGuard v.2.299 (protocoll) - hope it helps:
CovPassCheck v1.12.0 (de.rki.covpass.checkapp) allowed (green):
(For both: Currently no blocked rules.) |
Hello Jo-Achim, thank you for pointing out this bug (and I apologize for the late response). |
@JilAuraya, thank you. |
Additional information: Then I deleted the cache again plus the data from CovPass. The result is hardly surprising: after all vaccination certificates were scanned again, the message was no longer available. PS: WLAN was permanently available. According to the NetGuard protocol, there were no 'blocked' access attempts. |
As far as I can see, the worker to update the rules runs every 24 hours in the background. The message "Travel rules not up to date" gets displayed when the rules are older than 24 hours. Even when the requests do not get blocked by a firewall there is a small window where the message will appear due to the time it takes to update the rules. If there is an error and the worker goes into the exponential backoff this window might goes from a few minutes to a few hours. @JilAuraya @pucherd I suggest to change the time to show the message to 36 or 48 hours. This way there is small buffer where the app has time to update the rules without suggesting that the app is out of date. Another addition would be to show the actual error code when the background worker fails so that the user has a better indication whether something is wrong or not |
Hi @timokoenig, we replaced all workers with "on-demand" requests (v1.13.1) which will be done on users interaction -> so each time the user lands in the card overview we will check if the rules are older than 24 hours. |
@pucherd that's great to hear! I guess that will mitigate some issues with the background tasks |
Thank you, @pucherd
With the current version 1.13.2 the optional manual option "Update entry rules" is available. |
Thank you for the feedback @Jo-Achim. Can we close this ticket? |
Yes, I close, since the alternative implementation via the manual update is also a good solution. |
@Jo-Achim the manual update is a alternative solution the travel rules will be updated each time the app is started (of course if the the last update is older than 24 hours). |
Avoid duplicates
Technical details
Describe the bug
When calling CovPass v1.12.0 and calling "Check validity >", the following message is displayed in the "Check validity" dialog:
"Travel rules not up to date" ...
It seems to me that the app makes no attempt to update, because the notice is displayed immediately, despite the presence of WiFi.
In comparison to the previous version 1.11.1, the following is initially displayed if the above procedure is the same:
and then a few seconds later:
Steps to reproduce the issue
Make sure that the smartphone has an internet connection - in my case only via WLAN! (One smartphone (Samsung) is not allowed to access the internet via mobile phone provider, the second one (Nokia) does not have a SIM card.)
Expected behaviour
Ensuring that every time CovPass v1.12.0 is started, the 'out of date data for the entry rules' are updated via the existing Internet.
Cross reference: ["CovPass Check": Offline mode & WLAN]: "Internet connection required" although available ....
(Please do not be surprised about the version numbers of CovPass / CovPassCheck mentioned in the cross-reference, which are 'normal'; see Repeated version jumps / incomprehensible numbering of the versions in CovPass & CovPassCheck ....)
Possible Fix
Implementation of the update mechanism for the travel rules from version 1.11.1 or other corrections in the next version of CovPass.
Additional context
Open / not tested: similar behavior in CovPassCheck v 1.12.0.
PS: If helpful, a supplement for the above Samsung data:
CovPassCheck v.1.12.0 shows:
The text was updated successfully, but these errors were encountered: