Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge #14

Merged
merged 23 commits into from
Nov 19, 2019
Merged

merge #14

merged 23 commits into from
Nov 19, 2019

Conversation

DrFaust92
Copy link
Owner

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

DrFaust92 and others added 23 commits November 9, 2019 12:43
@DrFaust92
add cloudtrail support to keyvaluetags
9b3e036
@DrFaust92
add tag on create
5f04723 
use keyvaluetags
refactor tests
@DrFaust92
remove cloudtrail tag functions
d632cc2
@DrFaust92
fix tag test check
8a81f01
@DrFaust92
read after create
301aa78
@renovate-bot
Update module aws/aws-sdk-go to v1.25.36
131f0af
@gdavison
Adds instructions for correctly including acceptance test results in …
91e8ce2 
…a PR
@gdavison
Merge pull request #10901 from terraform-providers/d-clarify_acc_test…
9bb0dca 
…_instructions

Adds instructions for correctly including acceptance test results in a PR
@gdavison
Merge pull request #10900 from terraform-providers/renovate/github.co…
dd437e4 
…m-aws-aws-sdk-go-1.x

Update module aws/aws-sdk-go to v1.25.36
@gdavison
Merge pull request #10818 from DrFaust92/cloudtrail-keyvalue-tags
03ede95 
r/aws_cloudtrail - support Tag on create
@renovate-bot
Update module bflad/tfproviderlint to v0.5.1
f9429cd
@gdavison
Update CHANGELOG for #10818
7986e2c
@gdavison
Merge pull request #10885 from terraform-providers/renovate/github.co…
04aa79a 
…m-bflad-tfproviderlint-0.x

Update module bflad/tfproviderlint to v0.5.1
v2.37.0
b6443b6
@bflad
deps: Add missing checksums to go.sum
380119e 
Updated via:

```
go mod tidy
```
@bflad
Cleanup after v2.37.0 release
e925152
@bflad
New Resource: aws_eks_node_group (#10916)
71a088d 
Output from acceptance testing:

```
--- PASS: TestAccAWSEksNodeGroup_AmiType (1541.19s)
--- PASS: TestAccAWSEksNodeGroup_basic (1592.90s)
--- PASS: TestAccAWSEksNodeGroup_disappears (1474.40s)
--- PASS: TestAccAWSEksNodeGroup_DiskSize (1509.60s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes (1718.96s)
--- PASS: TestAccAWSEksNodeGroup_Labels (1674.47s)
--- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (1473.09s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1572.12s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1579.61s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1695.85s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1644.41s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1622.42s)
--- PASS: TestAccAWSEksNodeGroup_Tags (1614.55s)
--- PASS: TestAccAWSEksNodeGroup_Version (1721.66s)
```
v2.38.0
8129cfd
Cleanup after v2.38.0 release
7743a61
@bflad
Update CHANGELOG for #10916
cef67de
@aeschright
Add stale issue closer behavior (#10839)
d91001b
@aeschright
Fix permanent diff on aws_opsworks ssh_key and password (#10175)
f853a71 
Closes #165 
Closes #176 
Closes #4411
@aeschright
Update Changelog for #10175
7c67300
@DrFaust92 DrFaust92 merged commit b11372b into DrFaust92:master Nov 19, 2019
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DrFaust92 @renovate-bot @gdavison @bflad @aeschright