-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Filter for chained/animated nodes #4
Comments
I decided to implement option A because B seemed bit too brute and might cause undesired effects, I've made a PR but there's a caveat - it doesn't work on provided subtitle file example but I think it's due to node #318 which is probably a rare case or a typo. I haven't really worked on subtitle files in the past so I guess you'll have a better assessment than I, here are the relevant details:
My code works either if node 318's text had " by" after "Subtitles" in top row or 2nd row("U") didn't exist which I believe is a subtitle uploader which made a mistake in their ad. |
Node 318 was probably a mistake on my end, I had no examples on hand so I wrote that one out. Linking to #20 |
remove chained ads in case of regex-filter hit
This one is a bit trickier to handle and explain in text. Some subtitle uploaders have decided to add incredibly intrusive animated credits. They follow a similar format:
Right now subclean can handle nodes 319 to 324 but the preceding nodes remain. A special handler will need to be written that scans for these chained nodes. I'll probably end up doing it one of two ways.
Option A:
Option B:
The text was updated successfully, but these errors were encountered: