Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove chained ads in case of regex-filter hit #20

Merged
merged 2 commits into from
Aug 27, 2022

Conversation

Eytan414
Copy link
Contributor

I'm not really familiar with subtitles ads so I was working under the assumption that only the regex based filter yields a hit of chained nodes, so my solution is applied only for those cases.

I can also expand it to rest of the cases, my initial thought is to hold a node hit index array, and apply the fix for all those indexes right after the blacklist loop.

@DrKain
Copy link
Owner

DrKain commented Aug 27, 2022

Thanks for this. I'll need to do some testing locally before anything is merged.
If you wouldn't mind, could you please set up a custom arg for this functionality? Seeing as it's an experimental feature I'd prefer it not to be enabled by default.

src/index.ts Show resolved Hide resolved
@DrKain DrKain linked an issue Aug 27, 2022 that may be closed by this pull request
@Eytan414
Copy link
Contributor Author

Thanks for this. I'll need to do some testing locally before anything is merged. If you wouldn't mind, could you please set up a custom arg for this functionality? Seeing as it's an experimental feature I'd prefer it not to be enabled by default.

Yes, I'll push an update soon

@DrKain DrKain changed the base branch from main to issue-4 August 27, 2022 08:31
@DrKain DrKain merged commit 901ba95 into DrKain:issue-4 Aug 27, 2022
DrKain added a commit that referenced this pull request Aug 27, 2022
Reorganized the chain handler added in #20 as well as several minor code changes.
@DrKain
Copy link
Owner

DrKain commented Aug 27, 2022

Ended up changing a few things around, mostly var names and extra logging but it should be available in the 1.5.0 release published a moment ago.
You've been credited in the release notes too, thank you for the contribution.

@Eytan414
Copy link
Contributor Author

Yes I just saw, thank you! I didn't like the name too, and as for the other changes they're really helpful for maintainability - great library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Filter for chained/animated nodes
2 participants