Major rework of shutdown and reconnect logs to avoid zombie tasks and… #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper
added a commit
that referenced
this pull request
Mar 20, 2022
#6) Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper
added a commit
that referenced
this pull request
Mar 20, 2022
#6) Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper
added a commit
that referenced
this pull request
Mar 20, 2022
#6) Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper
added a commit
that referenced
this pull request
Mar 20, 2022
#6) Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper
added a commit
that referenced
this pull request
Mar 20, 2022
#6) Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper
added a commit
that referenced
this pull request
Mar 20, 2022
#6) Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper
added a commit
that referenced
this pull request
Mar 21, 2022
#6) Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper
added a commit
that referenced
this pull request
Mar 21, 2022
#6) Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper
added a commit
that referenced
this pull request
Mar 28, 2022
#6) Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper
added a commit
that referenced
this pull request
Mar 29, 2022
#6) Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper
added a commit
that referenced
this pull request
Mar 29, 2022
…ators#122) * WIP discord.VoiceProtocol * make similar of old socket_response behavior. * No longer pass voice_ws_func to node * Cleanup. * Fix tests. * More cleanup * More cleanup * Fix style. * hm yeah * Remove node.get_voice_ws, and replace it with client.is_closed. * Use Shard.is_closed instead of bot.is_closed. * Include methods from HTTPClient in Player. * ... forgot one. * Put back RESTClient to Player instead of Node. It needed Player.state to works properly. * Delete node._remove_player. Use player.disconnect force instead. * Add discord.py 2.0 changes * Fix unwanted voice events being passed * Fix 2/3 tests. * Reformat. * Assert from player. * Simplify this. * Improve get_channel logic (Cog-Creators#112) * Improve get_channel logic * Update fixtures * Style changes Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com> * Fix and complete the secure connection implementation (Cog-Creators#116) * Fix the partial implementation of a secure connection. * https 1 * address review Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com> * Add Exception classes to RLL (Cog-Creators#115) * Add RLL Specific errors and use them where appropriate * update exception name to remove "exception" and keep naming consistent with others * Add a Trace Logger class and use is across RLL to reduce log spam. (Cog-Creators#119) * Add a Trace Logger class and use is across RLL to reduce log spam. * formatting * Tweaks * fix wrong typehint * change from debug to verbose * update logs to not dump handled traceback on console * add some logging around `lavalink.close()` * add missing callback to tasks * reorder for better logging * Add RLL Specific errors and use them where appropriate * conflict resolution + cleanup * Major rework of shutdown and reconnect logs to avoid zombie tasks and… (#6) Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com> * conflict resolution with predas * welp * Conflict resolution between Develop and PredaaA/Feature/dpy-voiceprotocol * Add Exception classes to RLL (Cog-Creators#115) * Add RLL Specific errors and use them where appropriate * update exception name to remove "exception" and keep naming consistent with others * Add a Trace Logger class and use is across RLL to reduce log spam. (Cog-Creators#119) * Add a Trace Logger class and use is across RLL to reduce log spam. * formatting * Tweaks * fix wrong typehint * change from debug to verbose * update logs to not dump handled traceback on console * add some logging around `lavalink.close()` * add missing callback to tasks * reorder for better logging * Add RLL Specific errors and use them where appropriate * conflict resolution + cleanup * refix the conflict resolution * Update lavalink.py * address jack's review * typing, docs, style * address code review * type the event handler (dispatch) * Update lavalink/player.py Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com> * missed this? * Update lavalink.py Co-authored-by: PredaaA <46051820+PredaaA@users.noreply.github.com> Co-authored-by: aikaterna <20862007+aikaterna@users.noreply.github.com> Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… race conditions