Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes and improvements on settings #447

Merged
merged 33 commits into from
May 5, 2021

Conversation

123jimin
Copy link

@123jimin 123jimin commented Apr 7, 2021

  • Color settings and enum settings made sure not to be clipped because of insufficient scroll area
  • Previously hidden fullscreen setting added to settings page
  • Game window position now saved
  • Window outside of monitor display region now fixed according to the setting AdjustWindowPositionOnStartup (on by default)
    • It works a little bit annoyingly when the window was maximized before, due to different border size, but otherwise works fine.
    • The annoying behavior is not a regression (same thing happens on master branch of USC)
  • Settings renaming and relocations
    • "Display" renamed to "Visual" to reduce confusion between it with systems graphic settings
    • Offset settings moved from "Input" to "Game"
    • Other minor movements
  • Out-of-bounds enum settings now shown to be out-of-bound (also related to the next fix)
  • Fixes [Bug] Buttons cannot be remapped after removing an unused controller outside of the game. #439: slightly more detailed error messages
  • When binding controller buttons, the escape key will cancel the binding. (It's unfortunate that the same can't be done for keyboard key binding screen...)
  • Adjusted font baking algorithm so that required texture size for fallback font is reduced (32768 to 8192)
    • Any GPU supporting DirectX 10 should be able to bake the font texture now.
    • Partial baking support: if supported texture size is not big enough, only hiragana/katakana characters are baked.
      • This requires only 1024 x 1024 px texture support; any device supporting OpenGL ES 3.0 should be able to handle this.
  • Same for multiplayer chat, but partial baking is not supported (not a big problem as required texture size is still reduced)

break;
}

// Optimally, this should be set to the largest rectangle inside `bounds intersect windowRect`.
Copy link
Author

@123jimin 123jimin Apr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... but I didn't do this as the code will be too complex for a small task of relocating the window.

Drewol and others added 20 commits April 9, 2021 19:42
Fixed a bug where string skin settings were not loaded properly
Bumped up to C++17 and enabled /MP for all projects
Fix a case where auto laser time wouldn't be decremented
Fix regression in laser logic when turning in the opposite direction of an incoming laser
* ESC on controller button binding screen closes the binding prompt.
* Changed `Graphics` to `Visual`
* Moved offset settings from `Input` to `Game`
* Moved controller choice to the top
* Special button on invalid enum setting
@Drewol Drewol merged commit 1a26e73 into Drewol:develop May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants