Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make repositories descriptions translatable #337

Closed
ghost opened this issue May 3, 2023 · 2 comments · Fixed by #351
Closed

Make repositories descriptions translatable #337

ghost opened this issue May 3, 2023 · 2 comments · Fixed by #351
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented May 3, 2023

Also, do not fetch description from server if repo is from the default list (not added by user), so it will not override translation.
@ghost ghost added the enhancement New feature or request label May 3, 2023
@Iamlooker
Copy link
Member

All the active repositories fetch descriptions from the index, which are localized in Index-v2 but not many repo's support it. So I don't think we need to make these translatable. I will be closing this issue for now but you can always tag me back to reopen this repo

@Iamlooker Iamlooker closed this as not planned Won't fix, can't repro, duplicate, stale May 4, 2023
@BLumia
Copy link
Contributor

BLumia commented Jun 8, 2023

IndexV1 already contains localized data for displaying names and descriptions. I can submit a patch to add such support if you like. Can we reopen this issue?

@BLumia BLumia mentioned this issue Jun 8, 2023
Closed
BLumia added a commit to BLumia/Droid-ify that referenced this issue Jun 11, 2023
@BLumia
feat: display localized product name and description
09577b0 
When loading product data from indexV1, try to follow the user's locale
setting when possible so the information will be localized.

The `getBestLocale()` helper method was reused from F-droid source
code (part of `LocaleChooser.kt`). Other part wrote by myself.

Resolve: Droid-ify#337
@BLumia BLumia mentioned this issue Jun 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: display localized product name and description BLumia/Droid-ify
2 participants
@BLumia @Iamlooker