feat: display localized product name and description #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading product data from indexV1, try to follow the user's locale setting when possible so the information will be localized. The `getBestLocale()` helper method was reused from F-droid source code (part of `LocaleChooser.kt`). Other part wrote by myself. Resolve: Droid-ify#337
|
The test CI seems failed on |
No, we can ignore it for now. |
|
I will review the code in a while |
|
Thanks a lot for help with this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading product data from indexV1, try to follow the user's locale setting when possible so the information will be localized.
The
getBestLocale()helper method was reused from F-droid source code (part ofLocaleChooser.kt). Other part wrote by myself.